Merge tag 'drm-intel-next-2018-06-06' of git://anongit.freedesktop.org/drm/drm-intel...
[muen/linux.git] / drivers / gpu / drm / i915 / intel_sdvo.c
1 /*
2  * Copyright 2006 Dave Airlie <airlied@linux.ie>
3  * Copyright © 2006-2007 Intel Corporation
4  *   Jesse Barnes <jesse.barnes@intel.com>
5  *
6  * Permission is hereby granted, free of charge, to any person obtaining a
7  * copy of this software and associated documentation files (the "Software"),
8  * to deal in the Software without restriction, including without limitation
9  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10  * and/or sell copies of the Software, and to permit persons to whom the
11  * Software is furnished to do so, subject to the following conditions:
12  *
13  * The above copyright notice and this permission notice (including the next
14  * paragraph) shall be included in all copies or substantial portions of the
15  * Software.
16  *
17  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
20  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
22  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
23  * DEALINGS IN THE SOFTWARE.
24  *
25  * Authors:
26  *      Eric Anholt <eric@anholt.net>
27  */
28 #include <linux/i2c.h>
29 #include <linux/slab.h>
30 #include <linux/delay.h>
31 #include <linux/export.h>
32 #include <drm/drmP.h>
33 #include <drm/drm_atomic_helper.h>
34 #include <drm/drm_crtc.h>
35 #include <drm/drm_edid.h>
36 #include "intel_drv.h"
37 #include <drm/i915_drm.h>
38 #include "i915_drv.h"
39 #include "intel_sdvo_regs.h"
40
41 #define SDVO_TMDS_MASK (SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_TMDS1)
42 #define SDVO_RGB_MASK  (SDVO_OUTPUT_RGB0 | SDVO_OUTPUT_RGB1)
43 #define SDVO_LVDS_MASK (SDVO_OUTPUT_LVDS0 | SDVO_OUTPUT_LVDS1)
44 #define SDVO_TV_MASK   (SDVO_OUTPUT_CVBS0 | SDVO_OUTPUT_SVID0 | SDVO_OUTPUT_YPRPB0)
45
46 #define SDVO_OUTPUT_MASK (SDVO_TMDS_MASK | SDVO_RGB_MASK | SDVO_LVDS_MASK |\
47                         SDVO_TV_MASK)
48
49 #define IS_TV(c)        (c->output_flag & SDVO_TV_MASK)
50 #define IS_TMDS(c)      (c->output_flag & SDVO_TMDS_MASK)
51 #define IS_LVDS(c)      (c->output_flag & SDVO_LVDS_MASK)
52 #define IS_TV_OR_LVDS(c) (c->output_flag & (SDVO_TV_MASK | SDVO_LVDS_MASK))
53 #define IS_DIGITAL(c) (c->output_flag & (SDVO_TMDS_MASK | SDVO_LVDS_MASK))
54
55
56 static const char * const tv_format_names[] = {
57         "NTSC_M"   , "NTSC_J"  , "NTSC_443",
58         "PAL_B"    , "PAL_D"   , "PAL_G"   ,
59         "PAL_H"    , "PAL_I"   , "PAL_M"   ,
60         "PAL_N"    , "PAL_NC"  , "PAL_60"  ,
61         "SECAM_B"  , "SECAM_D" , "SECAM_G" ,
62         "SECAM_K"  , "SECAM_K1", "SECAM_L" ,
63         "SECAM_60"
64 };
65
66 #define TV_FORMAT_NUM  ARRAY_SIZE(tv_format_names)
67
68 struct intel_sdvo {
69         struct intel_encoder base;
70
71         struct i2c_adapter *i2c;
72         u8 slave_addr;
73
74         struct i2c_adapter ddc;
75
76         /* Register for the SDVO device: SDVOB or SDVOC */
77         i915_reg_t sdvo_reg;
78
79         /* Active outputs controlled by this SDVO output */
80         uint16_t controlled_output;
81
82         /*
83          * Capabilities of the SDVO device returned by
84          * intel_sdvo_get_capabilities()
85          */
86         struct intel_sdvo_caps caps;
87
88         /* Pixel clock limitations reported by the SDVO device, in kHz */
89         int pixel_clock_min, pixel_clock_max;
90
91         /*
92         * For multiple function SDVO device,
93         * this is for current attached outputs.
94         */
95         uint16_t attached_output;
96
97         /*
98          * Hotplug activation bits for this device
99          */
100         uint16_t hotplug_active;
101
102         /**
103          * This is set if we're going to treat the device as TV-out.
104          *
105          * While we have these nice friendly flags for output types that ought
106          * to decide this for us, the S-Video output on our HDMI+S-Video card
107          * shows up as RGB1 (VGA).
108          */
109         bool is_tv;
110
111         enum port port;
112
113         /**
114          * This is set if we treat the device as HDMI, instead of DVI.
115          */
116         bool is_hdmi;
117         bool has_hdmi_monitor;
118         bool has_hdmi_audio;
119         bool rgb_quant_range_selectable;
120
121         /**
122          * This is set if we detect output of sdvo device as LVDS and
123          * have a valid fixed mode to use with the panel.
124          */
125         bool is_lvds;
126
127         /**
128          * This is sdvo fixed pannel mode pointer
129          */
130         struct drm_display_mode *sdvo_lvds_fixed_mode;
131
132         /* DDC bus used by this SDVO encoder */
133         uint8_t ddc_bus;
134
135         /*
136          * the sdvo flag gets lost in round trip: dtd->adjusted_mode->dtd
137          */
138         uint8_t dtd_sdvo_flags;
139 };
140
141 struct intel_sdvo_connector {
142         struct intel_connector base;
143
144         /* Mark the type of connector */
145         uint16_t output_flag;
146
147         /* This contains all current supported TV format */
148         u8 tv_format_supported[TV_FORMAT_NUM];
149         int   format_supported_num;
150         struct drm_property *tv_format;
151
152         /* add the property for the SDVO-TV */
153         struct drm_property *left;
154         struct drm_property *right;
155         struct drm_property *top;
156         struct drm_property *bottom;
157         struct drm_property *hpos;
158         struct drm_property *vpos;
159         struct drm_property *contrast;
160         struct drm_property *saturation;
161         struct drm_property *hue;
162         struct drm_property *sharpness;
163         struct drm_property *flicker_filter;
164         struct drm_property *flicker_filter_adaptive;
165         struct drm_property *flicker_filter_2d;
166         struct drm_property *tv_chroma_filter;
167         struct drm_property *tv_luma_filter;
168         struct drm_property *dot_crawl;
169
170         /* add the property for the SDVO-TV/LVDS */
171         struct drm_property *brightness;
172
173         /* this is to get the range of margin.*/
174         u32 max_hscan, max_vscan;
175 };
176
177 struct intel_sdvo_connector_state {
178         /* base.base: tv.saturation/contrast/hue/brightness */
179         struct intel_digital_connector_state base;
180
181         struct {
182                 unsigned overscan_h, overscan_v, hpos, vpos, sharpness;
183                 unsigned flicker_filter, flicker_filter_2d, flicker_filter_adaptive;
184                 unsigned chroma_filter, luma_filter, dot_crawl;
185         } tv;
186 };
187
188 static struct intel_sdvo *to_sdvo(struct intel_encoder *encoder)
189 {
190         return container_of(encoder, struct intel_sdvo, base);
191 }
192
193 static struct intel_sdvo *intel_attached_sdvo(struct drm_connector *connector)
194 {
195         return to_sdvo(intel_attached_encoder(connector));
196 }
197
198 static struct intel_sdvo_connector *
199 to_intel_sdvo_connector(struct drm_connector *connector)
200 {
201         return container_of(connector, struct intel_sdvo_connector, base.base);
202 }
203
204 #define to_intel_sdvo_connector_state(conn_state) \
205         container_of((conn_state), struct intel_sdvo_connector_state, base.base)
206
207 static bool
208 intel_sdvo_output_setup(struct intel_sdvo *intel_sdvo, uint16_t flags);
209 static bool
210 intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo,
211                               struct intel_sdvo_connector *intel_sdvo_connector,
212                               int type);
213 static bool
214 intel_sdvo_create_enhance_property(struct intel_sdvo *intel_sdvo,
215                                    struct intel_sdvo_connector *intel_sdvo_connector);
216
217 /*
218  * Writes the SDVOB or SDVOC with the given value, but always writes both
219  * SDVOB and SDVOC to work around apparent hardware issues (according to
220  * comments in the BIOS).
221  */
222 static void intel_sdvo_write_sdvox(struct intel_sdvo *intel_sdvo, u32 val)
223 {
224         struct drm_device *dev = intel_sdvo->base.base.dev;
225         struct drm_i915_private *dev_priv = to_i915(dev);
226         u32 bval = val, cval = val;
227         int i;
228
229         if (HAS_PCH_SPLIT(dev_priv)) {
230                 I915_WRITE(intel_sdvo->sdvo_reg, val);
231                 POSTING_READ(intel_sdvo->sdvo_reg);
232                 /*
233                  * HW workaround, need to write this twice for issue
234                  * that may result in first write getting masked.
235                  */
236                 if (HAS_PCH_IBX(dev_priv)) {
237                         I915_WRITE(intel_sdvo->sdvo_reg, val);
238                         POSTING_READ(intel_sdvo->sdvo_reg);
239                 }
240                 return;
241         }
242
243         if (intel_sdvo->port == PORT_B)
244                 cval = I915_READ(GEN3_SDVOC);
245         else
246                 bval = I915_READ(GEN3_SDVOB);
247
248         /*
249          * Write the registers twice for luck. Sometimes,
250          * writing them only once doesn't appear to 'stick'.
251          * The BIOS does this too. Yay, magic
252          */
253         for (i = 0; i < 2; i++) {
254                 I915_WRITE(GEN3_SDVOB, bval);
255                 POSTING_READ(GEN3_SDVOB);
256
257                 I915_WRITE(GEN3_SDVOC, cval);
258                 POSTING_READ(GEN3_SDVOC);
259         }
260 }
261
262 static bool intel_sdvo_read_byte(struct intel_sdvo *intel_sdvo, u8 addr, u8 *ch)
263 {
264         struct i2c_msg msgs[] = {
265                 {
266                         .addr = intel_sdvo->slave_addr,
267                         .flags = 0,
268                         .len = 1,
269                         .buf = &addr,
270                 },
271                 {
272                         .addr = intel_sdvo->slave_addr,
273                         .flags = I2C_M_RD,
274                         .len = 1,
275                         .buf = ch,
276                 }
277         };
278         int ret;
279
280         if ((ret = i2c_transfer(intel_sdvo->i2c, msgs, 2)) == 2)
281                 return true;
282
283         DRM_DEBUG_KMS("i2c transfer returned %d\n", ret);
284         return false;
285 }
286
287 #define SDVO_CMD_NAME_ENTRY(cmd) {cmd, #cmd}
288 /** Mapping of command numbers to names, for debug output */
289 static const struct _sdvo_cmd_name {
290         u8 cmd;
291         const char *name;
292 } __attribute__ ((packed)) sdvo_cmd_names[] = {
293         SDVO_CMD_NAME_ENTRY(SDVO_CMD_RESET),
294         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_DEVICE_CAPS),
295         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FIRMWARE_REV),
296         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TRAINED_INPUTS),
297         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ACTIVE_OUTPUTS),
298         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ACTIVE_OUTPUTS),
299         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_IN_OUT_MAP),
300         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_IN_OUT_MAP),
301         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ATTACHED_DISPLAYS),
302         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HOT_PLUG_SUPPORT),
303         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ACTIVE_HOT_PLUG),
304         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ACTIVE_HOT_PLUG),
305         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INTERRUPT_EVENT_SOURCE),
306         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TARGET_INPUT),
307         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TARGET_OUTPUT),
308         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_TIMINGS_PART1),
309         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_TIMINGS_PART2),
310         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART1),
311         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART2),
312         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART1),
313         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OUTPUT_TIMINGS_PART1),
314         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OUTPUT_TIMINGS_PART2),
315         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_TIMINGS_PART1),
316         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_TIMINGS_PART2),
317         SDVO_CMD_NAME_ENTRY(SDVO_CMD_CREATE_PREFERRED_INPUT_TIMING),
318         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART1),
319         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART2),
320         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_PIXEL_CLOCK_RANGE),
321         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_PIXEL_CLOCK_RANGE),
322         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_CLOCK_RATE_MULTS),
323         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_CLOCK_RATE_MULT),
324         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CLOCK_RATE_MULT),
325         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_TV_FORMATS),
326         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_FORMAT),
327         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_FORMAT),
328         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_POWER_STATES),
329         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_POWER_STATE),
330         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ENCODER_POWER_STATE),
331         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_DISPLAY_POWER_STATE),
332         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CONTROL_BUS_SWITCH),
333         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SDTV_RESOLUTION_SUPPORT),
334         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SCALED_HDTV_RESOLUTION_SUPPORT),
335         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_ENHANCEMENTS),
336
337         /* Add the op code for SDVO enhancements */
338         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_HPOS),
339         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HPOS),
340         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HPOS),
341         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_VPOS),
342         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_VPOS),
343         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_VPOS),
344         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_SATURATION),
345         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SATURATION),
346         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_SATURATION),
347         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_HUE),
348         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HUE),
349         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HUE),
350         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_CONTRAST),
351         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_CONTRAST),
352         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CONTRAST),
353         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_BRIGHTNESS),
354         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_BRIGHTNESS),
355         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_BRIGHTNESS),
356         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_OVERSCAN_H),
357         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OVERSCAN_H),
358         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OVERSCAN_H),
359         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_OVERSCAN_V),
360         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OVERSCAN_V),
361         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OVERSCAN_V),
362         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER),
363         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER),
364         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER),
365         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER_ADAPTIVE),
366         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER_ADAPTIVE),
367         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER_ADAPTIVE),
368         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER_2D),
369         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER_2D),
370         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER_2D),
371         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_SHARPNESS),
372         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SHARPNESS),
373         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_SHARPNESS),
374         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_DOT_CRAWL),
375         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_DOT_CRAWL),
376         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_TV_CHROMA_FILTER),
377         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_CHROMA_FILTER),
378         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_CHROMA_FILTER),
379         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_TV_LUMA_FILTER),
380         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_LUMA_FILTER),
381         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_LUMA_FILTER),
382
383         /* HDMI op code */
384         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPP_ENCODE),
385         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ENCODE),
386         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ENCODE),
387         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_PIXEL_REPLI),
388         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PIXEL_REPLI),
389         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_COLORIMETRY_CAP),
390         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_COLORIMETRY),
391         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_COLORIMETRY),
392         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_AUDIO_ENCRYPT_PREFER),
393         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_AUDIO_STAT),
394         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_AUDIO_STAT),
395         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_INDEX),
396         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_INDEX),
397         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_INFO),
398         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_AV_SPLIT),
399         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_AV_SPLIT),
400         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_TXRATE),
401         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_TXRATE),
402         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_DATA),
403         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_DATA),
404 };
405
406 #define SDVO_NAME(svdo) ((svdo)->port == PORT_B ? "SDVOB" : "SDVOC")
407
408 static void intel_sdvo_debug_write(struct intel_sdvo *intel_sdvo, u8 cmd,
409                                    const void *args, int args_len)
410 {
411         int i, pos = 0;
412 #define BUF_LEN 256
413         char buffer[BUF_LEN];
414
415 #define BUF_PRINT(args...) \
416         pos += snprintf(buffer + pos, max_t(int, BUF_LEN - pos, 0), args)
417
418
419         for (i = 0; i < args_len; i++) {
420                 BUF_PRINT("%02X ", ((u8 *)args)[i]);
421         }
422         for (; i < 8; i++) {
423                 BUF_PRINT("   ");
424         }
425         for (i = 0; i < ARRAY_SIZE(sdvo_cmd_names); i++) {
426                 if (cmd == sdvo_cmd_names[i].cmd) {
427                         BUF_PRINT("(%s)", sdvo_cmd_names[i].name);
428                         break;
429                 }
430         }
431         if (i == ARRAY_SIZE(sdvo_cmd_names)) {
432                 BUF_PRINT("(%02X)", cmd);
433         }
434         BUG_ON(pos >= BUF_LEN - 1);
435 #undef BUF_PRINT
436 #undef BUF_LEN
437
438         DRM_DEBUG_KMS("%s: W: %02X %s\n", SDVO_NAME(intel_sdvo), cmd, buffer);
439 }
440
441 static const char * const cmd_status_names[] = {
442         "Power on",
443         "Success",
444         "Not supported",
445         "Invalid arg",
446         "Pending",
447         "Target not specified",
448         "Scaling not supported"
449 };
450
451 static bool __intel_sdvo_write_cmd(struct intel_sdvo *intel_sdvo, u8 cmd,
452                                    const void *args, int args_len,
453                                    bool unlocked)
454 {
455         u8 *buf, status;
456         struct i2c_msg *msgs;
457         int i, ret = true;
458
459         /* Would be simpler to allocate both in one go ? */
460         buf = kzalloc(args_len * 2 + 2, GFP_KERNEL);
461         if (!buf)
462                 return false;
463
464         msgs = kcalloc(args_len + 3, sizeof(*msgs), GFP_KERNEL);
465         if (!msgs) {
466                 kfree(buf);
467                 return false;
468         }
469
470         intel_sdvo_debug_write(intel_sdvo, cmd, args, args_len);
471
472         for (i = 0; i < args_len; i++) {
473                 msgs[i].addr = intel_sdvo->slave_addr;
474                 msgs[i].flags = 0;
475                 msgs[i].len = 2;
476                 msgs[i].buf = buf + 2 *i;
477                 buf[2*i + 0] = SDVO_I2C_ARG_0 - i;
478                 buf[2*i + 1] = ((u8*)args)[i];
479         }
480         msgs[i].addr = intel_sdvo->slave_addr;
481         msgs[i].flags = 0;
482         msgs[i].len = 2;
483         msgs[i].buf = buf + 2*i;
484         buf[2*i + 0] = SDVO_I2C_OPCODE;
485         buf[2*i + 1] = cmd;
486
487         /* the following two are to read the response */
488         status = SDVO_I2C_CMD_STATUS;
489         msgs[i+1].addr = intel_sdvo->slave_addr;
490         msgs[i+1].flags = 0;
491         msgs[i+1].len = 1;
492         msgs[i+1].buf = &status;
493
494         msgs[i+2].addr = intel_sdvo->slave_addr;
495         msgs[i+2].flags = I2C_M_RD;
496         msgs[i+2].len = 1;
497         msgs[i+2].buf = &status;
498
499         if (unlocked)
500                 ret = i2c_transfer(intel_sdvo->i2c, msgs, i+3);
501         else
502                 ret = __i2c_transfer(intel_sdvo->i2c, msgs, i+3);
503         if (ret < 0) {
504                 DRM_DEBUG_KMS("I2c transfer returned %d\n", ret);
505                 ret = false;
506                 goto out;
507         }
508         if (ret != i+3) {
509                 /* failure in I2C transfer */
510                 DRM_DEBUG_KMS("I2c transfer returned %d/%d\n", ret, i+3);
511                 ret = false;
512         }
513
514 out:
515         kfree(msgs);
516         kfree(buf);
517         return ret;
518 }
519
520 static bool intel_sdvo_write_cmd(struct intel_sdvo *intel_sdvo, u8 cmd,
521                                  const void *args, int args_len)
522 {
523         return __intel_sdvo_write_cmd(intel_sdvo, cmd, args, args_len, true);
524 }
525
526 static bool intel_sdvo_read_response(struct intel_sdvo *intel_sdvo,
527                                      void *response, int response_len)
528 {
529         u8 retry = 15; /* 5 quick checks, followed by 10 long checks */
530         u8 status;
531         int i, pos = 0;
532 #define BUF_LEN 256
533         char buffer[BUF_LEN];
534
535
536         /*
537          * The documentation states that all commands will be
538          * processed within 15µs, and that we need only poll
539          * the status byte a maximum of 3 times in order for the
540          * command to be complete.
541          *
542          * Check 5 times in case the hardware failed to read the docs.
543          *
544          * Also beware that the first response by many devices is to
545          * reply PENDING and stall for time. TVs are notorious for
546          * requiring longer than specified to complete their replies.
547          * Originally (in the DDX long ago), the delay was only ever 15ms
548          * with an additional delay of 30ms applied for TVs added later after
549          * many experiments. To accommodate both sets of delays, we do a
550          * sequence of slow checks if the device is falling behind and fails
551          * to reply within 5*15µs.
552          */
553         if (!intel_sdvo_read_byte(intel_sdvo,
554                                   SDVO_I2C_CMD_STATUS,
555                                   &status))
556                 goto log_fail;
557
558         while ((status == SDVO_CMD_STATUS_PENDING ||
559                 status == SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED) && --retry) {
560                 if (retry < 10)
561                         msleep(15);
562                 else
563                         udelay(15);
564
565                 if (!intel_sdvo_read_byte(intel_sdvo,
566                                           SDVO_I2C_CMD_STATUS,
567                                           &status))
568                         goto log_fail;
569         }
570
571 #define BUF_PRINT(args...) \
572         pos += snprintf(buffer + pos, max_t(int, BUF_LEN - pos, 0), args)
573
574         if (status <= SDVO_CMD_STATUS_SCALING_NOT_SUPP)
575                 BUF_PRINT("(%s)", cmd_status_names[status]);
576         else
577                 BUF_PRINT("(??? %d)", status);
578
579         if (status != SDVO_CMD_STATUS_SUCCESS)
580                 goto log_fail;
581
582         /* Read the command response */
583         for (i = 0; i < response_len; i++) {
584                 if (!intel_sdvo_read_byte(intel_sdvo,
585                                           SDVO_I2C_RETURN_0 + i,
586                                           &((u8 *)response)[i]))
587                         goto log_fail;
588                 BUF_PRINT(" %02X", ((u8 *)response)[i]);
589         }
590         BUG_ON(pos >= BUF_LEN - 1);
591 #undef BUF_PRINT
592 #undef BUF_LEN
593
594         DRM_DEBUG_KMS("%s: R: %s\n", SDVO_NAME(intel_sdvo), buffer);
595         return true;
596
597 log_fail:
598         DRM_DEBUG_KMS("%s: R: ... failed\n", SDVO_NAME(intel_sdvo));
599         return false;
600 }
601
602 static int intel_sdvo_get_pixel_multiplier(const struct drm_display_mode *adjusted_mode)
603 {
604         if (adjusted_mode->crtc_clock >= 100000)
605                 return 1;
606         else if (adjusted_mode->crtc_clock >= 50000)
607                 return 2;
608         else
609                 return 4;
610 }
611
612 static bool __intel_sdvo_set_control_bus_switch(struct intel_sdvo *intel_sdvo,
613                                                 u8 ddc_bus)
614 {
615         /* This must be the immediately preceding write before the i2c xfer */
616         return __intel_sdvo_write_cmd(intel_sdvo,
617                                       SDVO_CMD_SET_CONTROL_BUS_SWITCH,
618                                       &ddc_bus, 1, false);
619 }
620
621 static bool intel_sdvo_set_value(struct intel_sdvo *intel_sdvo, u8 cmd, const void *data, int len)
622 {
623         if (!intel_sdvo_write_cmd(intel_sdvo, cmd, data, len))
624                 return false;
625
626         return intel_sdvo_read_response(intel_sdvo, NULL, 0);
627 }
628
629 static bool
630 intel_sdvo_get_value(struct intel_sdvo *intel_sdvo, u8 cmd, void *value, int len)
631 {
632         if (!intel_sdvo_write_cmd(intel_sdvo, cmd, NULL, 0))
633                 return false;
634
635         return intel_sdvo_read_response(intel_sdvo, value, len);
636 }
637
638 static bool intel_sdvo_set_target_input(struct intel_sdvo *intel_sdvo)
639 {
640         struct intel_sdvo_set_target_input_args targets = {0};
641         return intel_sdvo_set_value(intel_sdvo,
642                                     SDVO_CMD_SET_TARGET_INPUT,
643                                     &targets, sizeof(targets));
644 }
645
646 /*
647  * Return whether each input is trained.
648  *
649  * This function is making an assumption about the layout of the response,
650  * which should be checked against the docs.
651  */
652 static bool intel_sdvo_get_trained_inputs(struct intel_sdvo *intel_sdvo, bool *input_1, bool *input_2)
653 {
654         struct intel_sdvo_get_trained_inputs_response response;
655
656         BUILD_BUG_ON(sizeof(response) != 1);
657         if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_TRAINED_INPUTS,
658                                   &response, sizeof(response)))
659                 return false;
660
661         *input_1 = response.input0_trained;
662         *input_2 = response.input1_trained;
663         return true;
664 }
665
666 static bool intel_sdvo_set_active_outputs(struct intel_sdvo *intel_sdvo,
667                                           u16 outputs)
668 {
669         return intel_sdvo_set_value(intel_sdvo,
670                                     SDVO_CMD_SET_ACTIVE_OUTPUTS,
671                                     &outputs, sizeof(outputs));
672 }
673
674 static bool intel_sdvo_get_active_outputs(struct intel_sdvo *intel_sdvo,
675                                           u16 *outputs)
676 {
677         return intel_sdvo_get_value(intel_sdvo,
678                                     SDVO_CMD_GET_ACTIVE_OUTPUTS,
679                                     outputs, sizeof(*outputs));
680 }
681
682 static bool intel_sdvo_set_encoder_power_state(struct intel_sdvo *intel_sdvo,
683                                                int mode)
684 {
685         u8 state = SDVO_ENCODER_STATE_ON;
686
687         switch (mode) {
688         case DRM_MODE_DPMS_ON:
689                 state = SDVO_ENCODER_STATE_ON;
690                 break;
691         case DRM_MODE_DPMS_STANDBY:
692                 state = SDVO_ENCODER_STATE_STANDBY;
693                 break;
694         case DRM_MODE_DPMS_SUSPEND:
695                 state = SDVO_ENCODER_STATE_SUSPEND;
696                 break;
697         case DRM_MODE_DPMS_OFF:
698                 state = SDVO_ENCODER_STATE_OFF;
699                 break;
700         }
701
702         return intel_sdvo_set_value(intel_sdvo,
703                                     SDVO_CMD_SET_ENCODER_POWER_STATE, &state, sizeof(state));
704 }
705
706 static bool intel_sdvo_get_input_pixel_clock_range(struct intel_sdvo *intel_sdvo,
707                                                    int *clock_min,
708                                                    int *clock_max)
709 {
710         struct intel_sdvo_pixel_clock_range clocks;
711
712         BUILD_BUG_ON(sizeof(clocks) != 4);
713         if (!intel_sdvo_get_value(intel_sdvo,
714                                   SDVO_CMD_GET_INPUT_PIXEL_CLOCK_RANGE,
715                                   &clocks, sizeof(clocks)))
716                 return false;
717
718         /* Convert the values from units of 10 kHz to kHz. */
719         *clock_min = clocks.min * 10;
720         *clock_max = clocks.max * 10;
721         return true;
722 }
723
724 static bool intel_sdvo_set_target_output(struct intel_sdvo *intel_sdvo,
725                                          u16 outputs)
726 {
727         return intel_sdvo_set_value(intel_sdvo,
728                                     SDVO_CMD_SET_TARGET_OUTPUT,
729                                     &outputs, sizeof(outputs));
730 }
731
732 static bool intel_sdvo_set_timing(struct intel_sdvo *intel_sdvo, u8 cmd,
733                                   struct intel_sdvo_dtd *dtd)
734 {
735         return intel_sdvo_set_value(intel_sdvo, cmd, &dtd->part1, sizeof(dtd->part1)) &&
736                 intel_sdvo_set_value(intel_sdvo, cmd + 1, &dtd->part2, sizeof(dtd->part2));
737 }
738
739 static bool intel_sdvo_get_timing(struct intel_sdvo *intel_sdvo, u8 cmd,
740                                   struct intel_sdvo_dtd *dtd)
741 {
742         return intel_sdvo_get_value(intel_sdvo, cmd, &dtd->part1, sizeof(dtd->part1)) &&
743                 intel_sdvo_get_value(intel_sdvo, cmd + 1, &dtd->part2, sizeof(dtd->part2));
744 }
745
746 static bool intel_sdvo_set_input_timing(struct intel_sdvo *intel_sdvo,
747                                          struct intel_sdvo_dtd *dtd)
748 {
749         return intel_sdvo_set_timing(intel_sdvo,
750                                      SDVO_CMD_SET_INPUT_TIMINGS_PART1, dtd);
751 }
752
753 static bool intel_sdvo_set_output_timing(struct intel_sdvo *intel_sdvo,
754                                          struct intel_sdvo_dtd *dtd)
755 {
756         return intel_sdvo_set_timing(intel_sdvo,
757                                      SDVO_CMD_SET_OUTPUT_TIMINGS_PART1, dtd);
758 }
759
760 static bool intel_sdvo_get_input_timing(struct intel_sdvo *intel_sdvo,
761                                         struct intel_sdvo_dtd *dtd)
762 {
763         return intel_sdvo_get_timing(intel_sdvo,
764                                      SDVO_CMD_GET_INPUT_TIMINGS_PART1, dtd);
765 }
766
767 static bool
768 intel_sdvo_create_preferred_input_timing(struct intel_sdvo *intel_sdvo,
769                                          uint16_t clock,
770                                          uint16_t width,
771                                          uint16_t height)
772 {
773         struct intel_sdvo_preferred_input_timing_args args;
774
775         memset(&args, 0, sizeof(args));
776         args.clock = clock;
777         args.width = width;
778         args.height = height;
779         args.interlace = 0;
780
781         if (intel_sdvo->is_lvds &&
782            (intel_sdvo->sdvo_lvds_fixed_mode->hdisplay != width ||
783             intel_sdvo->sdvo_lvds_fixed_mode->vdisplay != height))
784                 args.scaled = 1;
785
786         return intel_sdvo_set_value(intel_sdvo,
787                                     SDVO_CMD_CREATE_PREFERRED_INPUT_TIMING,
788                                     &args, sizeof(args));
789 }
790
791 static bool intel_sdvo_get_preferred_input_timing(struct intel_sdvo *intel_sdvo,
792                                                   struct intel_sdvo_dtd *dtd)
793 {
794         BUILD_BUG_ON(sizeof(dtd->part1) != 8);
795         BUILD_BUG_ON(sizeof(dtd->part2) != 8);
796         return intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART1,
797                                     &dtd->part1, sizeof(dtd->part1)) &&
798                 intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART2,
799                                      &dtd->part2, sizeof(dtd->part2));
800 }
801
802 static bool intel_sdvo_set_clock_rate_mult(struct intel_sdvo *intel_sdvo, u8 val)
803 {
804         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_CLOCK_RATE_MULT, &val, 1);
805 }
806
807 static void intel_sdvo_get_dtd_from_mode(struct intel_sdvo_dtd *dtd,
808                                          const struct drm_display_mode *mode)
809 {
810         uint16_t width, height;
811         uint16_t h_blank_len, h_sync_len, v_blank_len, v_sync_len;
812         uint16_t h_sync_offset, v_sync_offset;
813         int mode_clock;
814
815         memset(dtd, 0, sizeof(*dtd));
816
817         width = mode->hdisplay;
818         height = mode->vdisplay;
819
820         /* do some mode translations */
821         h_blank_len = mode->htotal - mode->hdisplay;
822         h_sync_len = mode->hsync_end - mode->hsync_start;
823
824         v_blank_len = mode->vtotal - mode->vdisplay;
825         v_sync_len = mode->vsync_end - mode->vsync_start;
826
827         h_sync_offset = mode->hsync_start - mode->hdisplay;
828         v_sync_offset = mode->vsync_start - mode->vdisplay;
829
830         mode_clock = mode->clock;
831         mode_clock /= 10;
832         dtd->part1.clock = mode_clock;
833
834         dtd->part1.h_active = width & 0xff;
835         dtd->part1.h_blank = h_blank_len & 0xff;
836         dtd->part1.h_high = (((width >> 8) & 0xf) << 4) |
837                 ((h_blank_len >> 8) & 0xf);
838         dtd->part1.v_active = height & 0xff;
839         dtd->part1.v_blank = v_blank_len & 0xff;
840         dtd->part1.v_high = (((height >> 8) & 0xf) << 4) |
841                 ((v_blank_len >> 8) & 0xf);
842
843         dtd->part2.h_sync_off = h_sync_offset & 0xff;
844         dtd->part2.h_sync_width = h_sync_len & 0xff;
845         dtd->part2.v_sync_off_width = (v_sync_offset & 0xf) << 4 |
846                 (v_sync_len & 0xf);
847         dtd->part2.sync_off_width_high = ((h_sync_offset & 0x300) >> 2) |
848                 ((h_sync_len & 0x300) >> 4) | ((v_sync_offset & 0x30) >> 2) |
849                 ((v_sync_len & 0x30) >> 4);
850
851         dtd->part2.dtd_flags = 0x18;
852         if (mode->flags & DRM_MODE_FLAG_INTERLACE)
853                 dtd->part2.dtd_flags |= DTD_FLAG_INTERLACE;
854         if (mode->flags & DRM_MODE_FLAG_PHSYNC)
855                 dtd->part2.dtd_flags |= DTD_FLAG_HSYNC_POSITIVE;
856         if (mode->flags & DRM_MODE_FLAG_PVSYNC)
857                 dtd->part2.dtd_flags |= DTD_FLAG_VSYNC_POSITIVE;
858
859         dtd->part2.v_sync_off_high = v_sync_offset & 0xc0;
860 }
861
862 static void intel_sdvo_get_mode_from_dtd(struct drm_display_mode *pmode,
863                                          const struct intel_sdvo_dtd *dtd)
864 {
865         struct drm_display_mode mode = {};
866
867         mode.hdisplay = dtd->part1.h_active;
868         mode.hdisplay += ((dtd->part1.h_high >> 4) & 0x0f) << 8;
869         mode.hsync_start = mode.hdisplay + dtd->part2.h_sync_off;
870         mode.hsync_start += (dtd->part2.sync_off_width_high & 0xc0) << 2;
871         mode.hsync_end = mode.hsync_start + dtd->part2.h_sync_width;
872         mode.hsync_end += (dtd->part2.sync_off_width_high & 0x30) << 4;
873         mode.htotal = mode.hdisplay + dtd->part1.h_blank;
874         mode.htotal += (dtd->part1.h_high & 0xf) << 8;
875
876         mode.vdisplay = dtd->part1.v_active;
877         mode.vdisplay += ((dtd->part1.v_high >> 4) & 0x0f) << 8;
878         mode.vsync_start = mode.vdisplay;
879         mode.vsync_start += (dtd->part2.v_sync_off_width >> 4) & 0xf;
880         mode.vsync_start += (dtd->part2.sync_off_width_high & 0x0c) << 2;
881         mode.vsync_start += dtd->part2.v_sync_off_high & 0xc0;
882         mode.vsync_end = mode.vsync_start +
883                 (dtd->part2.v_sync_off_width & 0xf);
884         mode.vsync_end += (dtd->part2.sync_off_width_high & 0x3) << 4;
885         mode.vtotal = mode.vdisplay + dtd->part1.v_blank;
886         mode.vtotal += (dtd->part1.v_high & 0xf) << 8;
887
888         mode.clock = dtd->part1.clock * 10;
889
890         if (dtd->part2.dtd_flags & DTD_FLAG_INTERLACE)
891                 mode.flags |= DRM_MODE_FLAG_INTERLACE;
892         if (dtd->part2.dtd_flags & DTD_FLAG_HSYNC_POSITIVE)
893                 mode.flags |= DRM_MODE_FLAG_PHSYNC;
894         else
895                 mode.flags |= DRM_MODE_FLAG_NHSYNC;
896         if (dtd->part2.dtd_flags & DTD_FLAG_VSYNC_POSITIVE)
897                 mode.flags |= DRM_MODE_FLAG_PVSYNC;
898         else
899                 mode.flags |= DRM_MODE_FLAG_NVSYNC;
900
901         drm_mode_set_crtcinfo(&mode, 0);
902
903         drm_mode_copy(pmode, &mode);
904 }
905
906 static bool intel_sdvo_check_supp_encode(struct intel_sdvo *intel_sdvo)
907 {
908         struct intel_sdvo_encode encode;
909
910         BUILD_BUG_ON(sizeof(encode) != 2);
911         return intel_sdvo_get_value(intel_sdvo,
912                                   SDVO_CMD_GET_SUPP_ENCODE,
913                                   &encode, sizeof(encode));
914 }
915
916 static bool intel_sdvo_set_encode(struct intel_sdvo *intel_sdvo,
917                                   uint8_t mode)
918 {
919         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_ENCODE, &mode, 1);
920 }
921
922 static bool intel_sdvo_set_colorimetry(struct intel_sdvo *intel_sdvo,
923                                        uint8_t mode)
924 {
925         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_COLORIMETRY, &mode, 1);
926 }
927
928 #if 0
929 static void intel_sdvo_dump_hdmi_buf(struct intel_sdvo *intel_sdvo)
930 {
931         int i, j;
932         uint8_t set_buf_index[2];
933         uint8_t av_split;
934         uint8_t buf_size;
935         uint8_t buf[48];
936         uint8_t *pos;
937
938         intel_sdvo_get_value(encoder, SDVO_CMD_GET_HBUF_AV_SPLIT, &av_split, 1);
939
940         for (i = 0; i <= av_split; i++) {
941                 set_buf_index[0] = i; set_buf_index[1] = 0;
942                 intel_sdvo_write_cmd(encoder, SDVO_CMD_SET_HBUF_INDEX,
943                                      set_buf_index, 2);
944                 intel_sdvo_write_cmd(encoder, SDVO_CMD_GET_HBUF_INFO, NULL, 0);
945                 intel_sdvo_read_response(encoder, &buf_size, 1);
946
947                 pos = buf;
948                 for (j = 0; j <= buf_size; j += 8) {
949                         intel_sdvo_write_cmd(encoder, SDVO_CMD_GET_HBUF_DATA,
950                                              NULL, 0);
951                         intel_sdvo_read_response(encoder, pos, 8);
952                         pos += 8;
953                 }
954         }
955 }
956 #endif
957
958 static bool intel_sdvo_write_infoframe(struct intel_sdvo *intel_sdvo,
959                                        unsigned if_index, uint8_t tx_rate,
960                                        const uint8_t *data, unsigned length)
961 {
962         uint8_t set_buf_index[2] = { if_index, 0 };
963         uint8_t hbuf_size, tmp[8];
964         int i;
965
966         if (!intel_sdvo_set_value(intel_sdvo,
967                                   SDVO_CMD_SET_HBUF_INDEX,
968                                   set_buf_index, 2))
969                 return false;
970
971         if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HBUF_INFO,
972                                   &hbuf_size, 1))
973                 return false;
974
975         /* Buffer size is 0 based, hooray! */
976         hbuf_size++;
977
978         DRM_DEBUG_KMS("writing sdvo hbuf: %i, hbuf_size %i, hbuf_size: %i\n",
979                       if_index, length, hbuf_size);
980
981         for (i = 0; i < hbuf_size; i += 8) {
982                 memset(tmp, 0, 8);
983                 if (i < length)
984                         memcpy(tmp, data + i, min_t(unsigned, 8, length - i));
985
986                 if (!intel_sdvo_set_value(intel_sdvo,
987                                           SDVO_CMD_SET_HBUF_DATA,
988                                           tmp, 8))
989                         return false;
990         }
991
992         return intel_sdvo_set_value(intel_sdvo,
993                                     SDVO_CMD_SET_HBUF_TXRATE,
994                                     &tx_rate, 1);
995 }
996
997 static bool intel_sdvo_set_avi_infoframe(struct intel_sdvo *intel_sdvo,
998                                          const struct intel_crtc_state *pipe_config)
999 {
1000         uint8_t sdvo_data[HDMI_INFOFRAME_SIZE(AVI)];
1001         union hdmi_infoframe frame;
1002         int ret;
1003         ssize_t len;
1004
1005         ret = drm_hdmi_avi_infoframe_from_display_mode(&frame.avi,
1006                                                        &pipe_config->base.adjusted_mode,
1007                                                        false);
1008         if (ret < 0) {
1009                 DRM_ERROR("couldn't fill AVI infoframe\n");
1010                 return false;
1011         }
1012
1013         if (intel_sdvo->rgb_quant_range_selectable) {
1014                 if (pipe_config->limited_color_range)
1015                         frame.avi.quantization_range =
1016                                 HDMI_QUANTIZATION_RANGE_LIMITED;
1017                 else
1018                         frame.avi.quantization_range =
1019                                 HDMI_QUANTIZATION_RANGE_FULL;
1020         }
1021
1022         len = hdmi_infoframe_pack(&frame, sdvo_data, sizeof(sdvo_data));
1023         if (len < 0)
1024                 return false;
1025
1026         return intel_sdvo_write_infoframe(intel_sdvo, SDVO_HBUF_INDEX_AVI_IF,
1027                                           SDVO_HBUF_TX_VSYNC,
1028                                           sdvo_data, sizeof(sdvo_data));
1029 }
1030
1031 static bool intel_sdvo_set_tv_format(struct intel_sdvo *intel_sdvo,
1032                                      const struct drm_connector_state *conn_state)
1033 {
1034         struct intel_sdvo_tv_format format;
1035         uint32_t format_map;
1036
1037         format_map = 1 << conn_state->tv.mode;
1038         memset(&format, 0, sizeof(format));
1039         memcpy(&format, &format_map, min(sizeof(format), sizeof(format_map)));
1040
1041         BUILD_BUG_ON(sizeof(format) != 6);
1042         return intel_sdvo_set_value(intel_sdvo,
1043                                     SDVO_CMD_SET_TV_FORMAT,
1044                                     &format, sizeof(format));
1045 }
1046
1047 static bool
1048 intel_sdvo_set_output_timings_from_mode(struct intel_sdvo *intel_sdvo,
1049                                         const struct drm_display_mode *mode)
1050 {
1051         struct intel_sdvo_dtd output_dtd;
1052
1053         if (!intel_sdvo_set_target_output(intel_sdvo,
1054                                           intel_sdvo->attached_output))
1055                 return false;
1056
1057         intel_sdvo_get_dtd_from_mode(&output_dtd, mode);
1058         if (!intel_sdvo_set_output_timing(intel_sdvo, &output_dtd))
1059                 return false;
1060
1061         return true;
1062 }
1063
1064 /*
1065  * Asks the sdvo controller for the preferred input mode given the output mode.
1066  * Unfortunately we have to set up the full output mode to do that.
1067  */
1068 static bool
1069 intel_sdvo_get_preferred_input_mode(struct intel_sdvo *intel_sdvo,
1070                                     const struct drm_display_mode *mode,
1071                                     struct drm_display_mode *adjusted_mode)
1072 {
1073         struct intel_sdvo_dtd input_dtd;
1074
1075         /* Reset the input timing to the screen. Assume always input 0. */
1076         if (!intel_sdvo_set_target_input(intel_sdvo))
1077                 return false;
1078
1079         if (!intel_sdvo_create_preferred_input_timing(intel_sdvo,
1080                                                       mode->clock / 10,
1081                                                       mode->hdisplay,
1082                                                       mode->vdisplay))
1083                 return false;
1084
1085         if (!intel_sdvo_get_preferred_input_timing(intel_sdvo,
1086                                                    &input_dtd))
1087                 return false;
1088
1089         intel_sdvo_get_mode_from_dtd(adjusted_mode, &input_dtd);
1090         intel_sdvo->dtd_sdvo_flags = input_dtd.part2.sdvo_flags;
1091
1092         return true;
1093 }
1094
1095 static void i9xx_adjust_sdvo_tv_clock(struct intel_crtc_state *pipe_config)
1096 {
1097         unsigned dotclock = pipe_config->port_clock;
1098         struct dpll *clock = &pipe_config->dpll;
1099
1100         /*
1101          * SDVO TV has fixed PLL values depend on its clock range,
1102          * this mirrors vbios setting.
1103          */
1104         if (dotclock >= 100000 && dotclock < 140500) {
1105                 clock->p1 = 2;
1106                 clock->p2 = 10;
1107                 clock->n = 3;
1108                 clock->m1 = 16;
1109                 clock->m2 = 8;
1110         } else if (dotclock >= 140500 && dotclock <= 200000) {
1111                 clock->p1 = 1;
1112                 clock->p2 = 10;
1113                 clock->n = 6;
1114                 clock->m1 = 12;
1115                 clock->m2 = 8;
1116         } else {
1117                 WARN(1, "SDVO TV clock out of range: %i\n", dotclock);
1118         }
1119
1120         pipe_config->clock_set = true;
1121 }
1122
1123 static bool intel_sdvo_compute_config(struct intel_encoder *encoder,
1124                                       struct intel_crtc_state *pipe_config,
1125                                       struct drm_connector_state *conn_state)
1126 {
1127         struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
1128         struct intel_sdvo_connector_state *intel_sdvo_state =
1129                 to_intel_sdvo_connector_state(conn_state);
1130         struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
1131         struct drm_display_mode *mode = &pipe_config->base.mode;
1132
1133         DRM_DEBUG_KMS("forcing bpc to 8 for SDVO\n");
1134         pipe_config->pipe_bpp = 8*3;
1135
1136         if (HAS_PCH_SPLIT(to_i915(encoder->base.dev)))
1137                 pipe_config->has_pch_encoder = true;
1138
1139         /*
1140          * We need to construct preferred input timings based on our
1141          * output timings.  To do that, we have to set the output
1142          * timings, even though this isn't really the right place in
1143          * the sequence to do it. Oh well.
1144          */
1145         if (intel_sdvo->is_tv) {
1146                 if (!intel_sdvo_set_output_timings_from_mode(intel_sdvo, mode))
1147                         return false;
1148
1149                 (void) intel_sdvo_get_preferred_input_mode(intel_sdvo,
1150                                                            mode,
1151                                                            adjusted_mode);
1152                 pipe_config->sdvo_tv_clock = true;
1153         } else if (intel_sdvo->is_lvds) {
1154                 if (!intel_sdvo_set_output_timings_from_mode(intel_sdvo,
1155                                                              intel_sdvo->sdvo_lvds_fixed_mode))
1156                         return false;
1157
1158                 (void) intel_sdvo_get_preferred_input_mode(intel_sdvo,
1159                                                            mode,
1160                                                            adjusted_mode);
1161         }
1162
1163         /*
1164          * Make the CRTC code factor in the SDVO pixel multiplier.  The
1165          * SDVO device will factor out the multiplier during mode_set.
1166          */
1167         pipe_config->pixel_multiplier =
1168                 intel_sdvo_get_pixel_multiplier(adjusted_mode);
1169
1170         if (intel_sdvo_state->base.force_audio != HDMI_AUDIO_OFF_DVI)
1171                 pipe_config->has_hdmi_sink = intel_sdvo->has_hdmi_monitor;
1172
1173         if (intel_sdvo_state->base.force_audio == HDMI_AUDIO_ON ||
1174             (intel_sdvo_state->base.force_audio == HDMI_AUDIO_AUTO && intel_sdvo->has_hdmi_audio))
1175                 pipe_config->has_audio = true;
1176
1177         if (intel_sdvo_state->base.broadcast_rgb == INTEL_BROADCAST_RGB_AUTO) {
1178                 /*
1179                  * See CEA-861-E - 5.1 Default Encoding Parameters
1180                  *
1181                  * FIXME: This bit is only valid when using TMDS encoding and 8
1182                  * bit per color mode.
1183                  */
1184                 if (pipe_config->has_hdmi_sink &&
1185                     drm_match_cea_mode(adjusted_mode) > 1)
1186                         pipe_config->limited_color_range = true;
1187         } else {
1188                 if (pipe_config->has_hdmi_sink &&
1189                     intel_sdvo_state->base.broadcast_rgb == INTEL_BROADCAST_RGB_LIMITED)
1190                         pipe_config->limited_color_range = true;
1191         }
1192
1193         /* Clock computation needs to happen after pixel multiplier. */
1194         if (intel_sdvo->is_tv)
1195                 i9xx_adjust_sdvo_tv_clock(pipe_config);
1196
1197         /* Set user selected PAR to incoming mode's member */
1198         if (intel_sdvo->is_hdmi)
1199                 adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio;
1200
1201         return true;
1202 }
1203
1204 #define UPDATE_PROPERTY(input, NAME) \
1205         do { \
1206                 val = input; \
1207                 intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_##NAME, &val, sizeof(val)); \
1208         } while (0)
1209
1210 static void intel_sdvo_update_props(struct intel_sdvo *intel_sdvo,
1211                                     const struct intel_sdvo_connector_state *sdvo_state)
1212 {
1213         const struct drm_connector_state *conn_state = &sdvo_state->base.base;
1214         struct intel_sdvo_connector *intel_sdvo_conn =
1215                 to_intel_sdvo_connector(conn_state->connector);
1216         uint16_t val;
1217
1218         if (intel_sdvo_conn->left)
1219                 UPDATE_PROPERTY(sdvo_state->tv.overscan_h, OVERSCAN_H);
1220
1221         if (intel_sdvo_conn->top)
1222                 UPDATE_PROPERTY(sdvo_state->tv.overscan_v, OVERSCAN_V);
1223
1224         if (intel_sdvo_conn->hpos)
1225                 UPDATE_PROPERTY(sdvo_state->tv.hpos, HPOS);
1226
1227         if (intel_sdvo_conn->vpos)
1228                 UPDATE_PROPERTY(sdvo_state->tv.vpos, VPOS);
1229
1230         if (intel_sdvo_conn->saturation)
1231                 UPDATE_PROPERTY(conn_state->tv.saturation, SATURATION);
1232
1233         if (intel_sdvo_conn->contrast)
1234                 UPDATE_PROPERTY(conn_state->tv.contrast, CONTRAST);
1235
1236         if (intel_sdvo_conn->hue)
1237                 UPDATE_PROPERTY(conn_state->tv.hue, HUE);
1238
1239         if (intel_sdvo_conn->brightness)
1240                 UPDATE_PROPERTY(conn_state->tv.brightness, BRIGHTNESS);
1241
1242         if (intel_sdvo_conn->sharpness)
1243                 UPDATE_PROPERTY(sdvo_state->tv.sharpness, SHARPNESS);
1244
1245         if (intel_sdvo_conn->flicker_filter)
1246                 UPDATE_PROPERTY(sdvo_state->tv.flicker_filter, FLICKER_FILTER);
1247
1248         if (intel_sdvo_conn->flicker_filter_2d)
1249                 UPDATE_PROPERTY(sdvo_state->tv.flicker_filter_2d, FLICKER_FILTER_2D);
1250
1251         if (intel_sdvo_conn->flicker_filter_adaptive)
1252                 UPDATE_PROPERTY(sdvo_state->tv.flicker_filter_adaptive, FLICKER_FILTER_ADAPTIVE);
1253
1254         if (intel_sdvo_conn->tv_chroma_filter)
1255                 UPDATE_PROPERTY(sdvo_state->tv.chroma_filter, TV_CHROMA_FILTER);
1256
1257         if (intel_sdvo_conn->tv_luma_filter)
1258                 UPDATE_PROPERTY(sdvo_state->tv.luma_filter, TV_LUMA_FILTER);
1259
1260         if (intel_sdvo_conn->dot_crawl)
1261                 UPDATE_PROPERTY(sdvo_state->tv.dot_crawl, DOT_CRAWL);
1262
1263 #undef UPDATE_PROPERTY
1264 }
1265
1266 static void intel_sdvo_pre_enable(struct intel_encoder *intel_encoder,
1267                                   const struct intel_crtc_state *crtc_state,
1268                                   const struct drm_connector_state *conn_state)
1269 {
1270         struct drm_i915_private *dev_priv = to_i915(intel_encoder->base.dev);
1271         struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
1272         const struct drm_display_mode *adjusted_mode = &crtc_state->base.adjusted_mode;
1273         const struct intel_sdvo_connector_state *sdvo_state =
1274                 to_intel_sdvo_connector_state(conn_state);
1275         const struct drm_display_mode *mode = &crtc_state->base.mode;
1276         struct intel_sdvo *intel_sdvo = to_sdvo(intel_encoder);
1277         u32 sdvox;
1278         struct intel_sdvo_in_out_map in_out;
1279         struct intel_sdvo_dtd input_dtd, output_dtd;
1280         int rate;
1281
1282         intel_sdvo_update_props(intel_sdvo, sdvo_state);
1283
1284         /*
1285          * First, set the input mapping for the first input to our controlled
1286          * output. This is only correct if we're a single-input device, in
1287          * which case the first input is the output from the appropriate SDVO
1288          * channel on the motherboard.  In a two-input device, the first input
1289          * will be SDVOB and the second SDVOC.
1290          */
1291         in_out.in0 = intel_sdvo->attached_output;
1292         in_out.in1 = 0;
1293
1294         intel_sdvo_set_value(intel_sdvo,
1295                              SDVO_CMD_SET_IN_OUT_MAP,
1296                              &in_out, sizeof(in_out));
1297
1298         /* Set the output timings to the screen */
1299         if (!intel_sdvo_set_target_output(intel_sdvo,
1300                                           intel_sdvo->attached_output))
1301                 return;
1302
1303         /* lvds has a special fixed output timing. */
1304         if (intel_sdvo->is_lvds)
1305                 intel_sdvo_get_dtd_from_mode(&output_dtd,
1306                                              intel_sdvo->sdvo_lvds_fixed_mode);
1307         else
1308                 intel_sdvo_get_dtd_from_mode(&output_dtd, mode);
1309         if (!intel_sdvo_set_output_timing(intel_sdvo, &output_dtd))
1310                 DRM_INFO("Setting output timings on %s failed\n",
1311                          SDVO_NAME(intel_sdvo));
1312
1313         /* Set the input timing to the screen. Assume always input 0. */
1314         if (!intel_sdvo_set_target_input(intel_sdvo))
1315                 return;
1316
1317         if (crtc_state->has_hdmi_sink) {
1318                 intel_sdvo_set_encode(intel_sdvo, SDVO_ENCODE_HDMI);
1319                 intel_sdvo_set_colorimetry(intel_sdvo,
1320                                            SDVO_COLORIMETRY_RGB256);
1321                 intel_sdvo_set_avi_infoframe(intel_sdvo, crtc_state);
1322         } else
1323                 intel_sdvo_set_encode(intel_sdvo, SDVO_ENCODE_DVI);
1324
1325         if (intel_sdvo->is_tv &&
1326             !intel_sdvo_set_tv_format(intel_sdvo, conn_state))
1327                 return;
1328
1329         intel_sdvo_get_dtd_from_mode(&input_dtd, adjusted_mode);
1330
1331         if (intel_sdvo->is_tv || intel_sdvo->is_lvds)
1332                 input_dtd.part2.sdvo_flags = intel_sdvo->dtd_sdvo_flags;
1333         if (!intel_sdvo_set_input_timing(intel_sdvo, &input_dtd))
1334                 DRM_INFO("Setting input timings on %s failed\n",
1335                          SDVO_NAME(intel_sdvo));
1336
1337         switch (crtc_state->pixel_multiplier) {
1338         default:
1339                 WARN(1, "unknown pixel multiplier specified\n");
1340         case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break;
1341         case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break;
1342         case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break;
1343         }
1344         if (!intel_sdvo_set_clock_rate_mult(intel_sdvo, rate))
1345                 return;
1346
1347         /* Set the SDVO control regs. */
1348         if (INTEL_GEN(dev_priv) >= 4) {
1349                 /* The real mode polarity is set by the SDVO commands, using
1350                  * struct intel_sdvo_dtd. */
1351                 sdvox = SDVO_VSYNC_ACTIVE_HIGH | SDVO_HSYNC_ACTIVE_HIGH;
1352                 if (!HAS_PCH_SPLIT(dev_priv) && crtc_state->limited_color_range)
1353                         sdvox |= HDMI_COLOR_RANGE_16_235;
1354                 if (INTEL_GEN(dev_priv) < 5)
1355                         sdvox |= SDVO_BORDER_ENABLE;
1356         } else {
1357                 sdvox = I915_READ(intel_sdvo->sdvo_reg);
1358                 if (intel_sdvo->port == PORT_B)
1359                         sdvox &= SDVOB_PRESERVE_MASK;
1360                 else
1361                         sdvox &= SDVOC_PRESERVE_MASK;
1362                 sdvox |= (9 << 19) | SDVO_BORDER_ENABLE;
1363         }
1364
1365         if (HAS_PCH_CPT(dev_priv))
1366                 sdvox |= SDVO_PIPE_SEL_CPT(crtc->pipe);
1367         else
1368                 sdvox |= SDVO_PIPE_SEL(crtc->pipe);
1369
1370         if (crtc_state->has_audio) {
1371                 WARN_ON_ONCE(INTEL_GEN(dev_priv) < 4);
1372                 sdvox |= SDVO_AUDIO_ENABLE;
1373         }
1374
1375         if (INTEL_GEN(dev_priv) >= 4) {
1376                 /* done in crtc_mode_set as the dpll_md reg must be written early */
1377         } else if (IS_I945G(dev_priv) || IS_I945GM(dev_priv) ||
1378                    IS_G33(dev_priv) || IS_PINEVIEW(dev_priv)) {
1379                 /* done in crtc_mode_set as it lives inside the dpll register */
1380         } else {
1381                 sdvox |= (crtc_state->pixel_multiplier - 1)
1382                         << SDVO_PORT_MULTIPLY_SHIFT;
1383         }
1384
1385         if (input_dtd.part2.sdvo_flags & SDVO_NEED_TO_STALL &&
1386             INTEL_GEN(dev_priv) < 5)
1387                 sdvox |= SDVO_STALL_SELECT;
1388         intel_sdvo_write_sdvox(intel_sdvo, sdvox);
1389 }
1390
1391 static bool intel_sdvo_connector_get_hw_state(struct intel_connector *connector)
1392 {
1393         struct intel_sdvo_connector *intel_sdvo_connector =
1394                 to_intel_sdvo_connector(&connector->base);
1395         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(&connector->base);
1396         u16 active_outputs = 0;
1397
1398         intel_sdvo_get_active_outputs(intel_sdvo, &active_outputs);
1399
1400         if (active_outputs & intel_sdvo_connector->output_flag)
1401                 return true;
1402         else
1403                 return false;
1404 }
1405
1406 bool intel_sdvo_port_enabled(struct drm_i915_private *dev_priv,
1407                              i915_reg_t sdvo_reg, enum pipe *pipe)
1408 {
1409         u32 val;
1410
1411         val = I915_READ(sdvo_reg);
1412
1413         /* asserts want to know the pipe even if the port is disabled */
1414         if (HAS_PCH_CPT(dev_priv))
1415                 *pipe = (val & SDVO_PIPE_SEL_MASK_CPT) >> SDVO_PIPE_SEL_SHIFT_CPT;
1416         else if (IS_CHERRYVIEW(dev_priv))
1417                 *pipe = (val & SDVO_PIPE_SEL_MASK_CHV) >> SDVO_PIPE_SEL_SHIFT_CHV;
1418         else
1419                 *pipe = (val & SDVO_PIPE_SEL_MASK) >> SDVO_PIPE_SEL_SHIFT;
1420
1421         return val & SDVO_ENABLE;
1422 }
1423
1424 static bool intel_sdvo_get_hw_state(struct intel_encoder *encoder,
1425                                     enum pipe *pipe)
1426 {
1427         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1428         struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
1429         u16 active_outputs = 0;
1430         bool ret;
1431
1432         intel_sdvo_get_active_outputs(intel_sdvo, &active_outputs);
1433
1434         ret = intel_sdvo_port_enabled(dev_priv, intel_sdvo->sdvo_reg, pipe);
1435
1436         return ret || active_outputs;
1437 }
1438
1439 static void intel_sdvo_get_config(struct intel_encoder *encoder,
1440                                   struct intel_crtc_state *pipe_config)
1441 {
1442         struct drm_device *dev = encoder->base.dev;
1443         struct drm_i915_private *dev_priv = to_i915(dev);
1444         struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
1445         struct intel_sdvo_dtd dtd;
1446         int encoder_pixel_multiplier = 0;
1447         int dotclock;
1448         u32 flags = 0, sdvox;
1449         u8 val;
1450         bool ret;
1451
1452         pipe_config->output_types |= BIT(INTEL_OUTPUT_SDVO);
1453
1454         sdvox = I915_READ(intel_sdvo->sdvo_reg);
1455
1456         ret = intel_sdvo_get_input_timing(intel_sdvo, &dtd);
1457         if (!ret) {
1458                 /*
1459                  * Some sdvo encoders are not spec compliant and don't
1460                  * implement the mandatory get_timings function.
1461                  */
1462                 DRM_DEBUG_DRIVER("failed to retrieve SDVO DTD\n");
1463                 pipe_config->quirks |= PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS;
1464         } else {
1465                 if (dtd.part2.dtd_flags & DTD_FLAG_HSYNC_POSITIVE)
1466                         flags |= DRM_MODE_FLAG_PHSYNC;
1467                 else
1468                         flags |= DRM_MODE_FLAG_NHSYNC;
1469
1470                 if (dtd.part2.dtd_flags & DTD_FLAG_VSYNC_POSITIVE)
1471                         flags |= DRM_MODE_FLAG_PVSYNC;
1472                 else
1473                         flags |= DRM_MODE_FLAG_NVSYNC;
1474         }
1475
1476         pipe_config->base.adjusted_mode.flags |= flags;
1477
1478         /*
1479          * pixel multiplier readout is tricky: Only on i915g/gm it is stored in
1480          * the sdvo port register, on all other platforms it is part of the dpll
1481          * state. Since the general pipe state readout happens before the
1482          * encoder->get_config we so already have a valid pixel multplier on all
1483          * other platfroms.
1484          */
1485         if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) {
1486                 pipe_config->pixel_multiplier =
1487                         ((sdvox & SDVO_PORT_MULTIPLY_MASK)
1488                          >> SDVO_PORT_MULTIPLY_SHIFT) + 1;
1489         }
1490
1491         dotclock = pipe_config->port_clock;
1492
1493         if (pipe_config->pixel_multiplier)
1494                 dotclock /= pipe_config->pixel_multiplier;
1495
1496         pipe_config->base.adjusted_mode.crtc_clock = dotclock;
1497
1498         /* Cross check the port pixel multiplier with the sdvo encoder state. */
1499         if (intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_CLOCK_RATE_MULT,
1500                                  &val, 1)) {
1501                 switch (val) {
1502                 case SDVO_CLOCK_RATE_MULT_1X:
1503                         encoder_pixel_multiplier = 1;
1504                         break;
1505                 case SDVO_CLOCK_RATE_MULT_2X:
1506                         encoder_pixel_multiplier = 2;
1507                         break;
1508                 case SDVO_CLOCK_RATE_MULT_4X:
1509                         encoder_pixel_multiplier = 4;
1510                         break;
1511                 }
1512         }
1513
1514         if (sdvox & HDMI_COLOR_RANGE_16_235)
1515                 pipe_config->limited_color_range = true;
1516
1517         if (sdvox & SDVO_AUDIO_ENABLE)
1518                 pipe_config->has_audio = true;
1519
1520         if (intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_ENCODE,
1521                                  &val, 1)) {
1522                 if (val == SDVO_ENCODE_HDMI)
1523                         pipe_config->has_hdmi_sink = true;
1524         }
1525
1526         WARN(encoder_pixel_multiplier != pipe_config->pixel_multiplier,
1527              "SDVO pixel multiplier mismatch, port: %i, encoder: %i\n",
1528              pipe_config->pixel_multiplier, encoder_pixel_multiplier);
1529 }
1530
1531 static void intel_disable_sdvo(struct intel_encoder *encoder,
1532                                const struct intel_crtc_state *old_crtc_state,
1533                                const struct drm_connector_state *conn_state)
1534 {
1535         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1536         struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
1537         struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
1538         u32 temp;
1539
1540         intel_sdvo_set_active_outputs(intel_sdvo, 0);
1541         if (0)
1542                 intel_sdvo_set_encoder_power_state(intel_sdvo,
1543                                                    DRM_MODE_DPMS_OFF);
1544
1545         temp = I915_READ(intel_sdvo->sdvo_reg);
1546
1547         temp &= ~SDVO_ENABLE;
1548         intel_sdvo_write_sdvox(intel_sdvo, temp);
1549
1550         /*
1551          * HW workaround for IBX, we need to move the port
1552          * to transcoder A after disabling it to allow the
1553          * matching DP port to be enabled on transcoder A.
1554          */
1555         if (HAS_PCH_IBX(dev_priv) && crtc->pipe == PIPE_B) {
1556                 /*
1557                  * We get CPU/PCH FIFO underruns on the other pipe when
1558                  * doing the workaround. Sweep them under the rug.
1559                  */
1560                 intel_set_cpu_fifo_underrun_reporting(dev_priv, PIPE_A, false);
1561                 intel_set_pch_fifo_underrun_reporting(dev_priv, PIPE_A, false);
1562
1563                 temp &= ~SDVO_PIPE_SEL_MASK;
1564                 temp |= SDVO_ENABLE | SDVO_PIPE_SEL(PIPE_A);
1565                 intel_sdvo_write_sdvox(intel_sdvo, temp);
1566
1567                 temp &= ~SDVO_ENABLE;
1568                 intel_sdvo_write_sdvox(intel_sdvo, temp);
1569
1570                 intel_wait_for_vblank_if_active(dev_priv, PIPE_A);
1571                 intel_set_cpu_fifo_underrun_reporting(dev_priv, PIPE_A, true);
1572                 intel_set_pch_fifo_underrun_reporting(dev_priv, PIPE_A, true);
1573         }
1574 }
1575
1576 static void pch_disable_sdvo(struct intel_encoder *encoder,
1577                              const struct intel_crtc_state *old_crtc_state,
1578                              const struct drm_connector_state *old_conn_state)
1579 {
1580 }
1581
1582 static void pch_post_disable_sdvo(struct intel_encoder *encoder,
1583                                   const struct intel_crtc_state *old_crtc_state,
1584                                   const struct drm_connector_state *old_conn_state)
1585 {
1586         intel_disable_sdvo(encoder, old_crtc_state, old_conn_state);
1587 }
1588
1589 static void intel_enable_sdvo(struct intel_encoder *encoder,
1590                               const struct intel_crtc_state *pipe_config,
1591                               const struct drm_connector_state *conn_state)
1592 {
1593         struct drm_device *dev = encoder->base.dev;
1594         struct drm_i915_private *dev_priv = to_i915(dev);
1595         struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
1596         struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->base.crtc);
1597         u32 temp;
1598         bool input1, input2;
1599         int i;
1600         bool success;
1601
1602         temp = I915_READ(intel_sdvo->sdvo_reg);
1603         temp |= SDVO_ENABLE;
1604         intel_sdvo_write_sdvox(intel_sdvo, temp);
1605
1606         for (i = 0; i < 2; i++)
1607                 intel_wait_for_vblank(dev_priv, intel_crtc->pipe);
1608
1609         success = intel_sdvo_get_trained_inputs(intel_sdvo, &input1, &input2);
1610         /*
1611          * Warn if the device reported failure to sync.
1612          *
1613          * A lot of SDVO devices fail to notify of sync, but it's
1614          * a given it the status is a success, we succeeded.
1615          */
1616         if (success && !input1) {
1617                 DRM_DEBUG_KMS("First %s output reported failure to "
1618                                 "sync\n", SDVO_NAME(intel_sdvo));
1619         }
1620
1621         if (0)
1622                 intel_sdvo_set_encoder_power_state(intel_sdvo,
1623                                                    DRM_MODE_DPMS_ON);
1624         intel_sdvo_set_active_outputs(intel_sdvo, intel_sdvo->attached_output);
1625 }
1626
1627 static enum drm_mode_status
1628 intel_sdvo_mode_valid(struct drm_connector *connector,
1629                       struct drm_display_mode *mode)
1630 {
1631         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1632         int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
1633
1634         if (intel_sdvo->pixel_clock_min > mode->clock)
1635                 return MODE_CLOCK_LOW;
1636
1637         if (intel_sdvo->pixel_clock_max < mode->clock)
1638                 return MODE_CLOCK_HIGH;
1639
1640         if (mode->clock > max_dotclk)
1641                 return MODE_CLOCK_HIGH;
1642
1643         if (intel_sdvo->is_lvds) {
1644                 if (mode->hdisplay > intel_sdvo->sdvo_lvds_fixed_mode->hdisplay)
1645                         return MODE_PANEL;
1646
1647                 if (mode->vdisplay > intel_sdvo->sdvo_lvds_fixed_mode->vdisplay)
1648                         return MODE_PANEL;
1649         }
1650
1651         return MODE_OK;
1652 }
1653
1654 static bool intel_sdvo_get_capabilities(struct intel_sdvo *intel_sdvo, struct intel_sdvo_caps *caps)
1655 {
1656         BUILD_BUG_ON(sizeof(*caps) != 8);
1657         if (!intel_sdvo_get_value(intel_sdvo,
1658                                   SDVO_CMD_GET_DEVICE_CAPS,
1659                                   caps, sizeof(*caps)))
1660                 return false;
1661
1662         DRM_DEBUG_KMS("SDVO capabilities:\n"
1663                       "  vendor_id: %d\n"
1664                       "  device_id: %d\n"
1665                       "  device_rev_id: %d\n"
1666                       "  sdvo_version_major: %d\n"
1667                       "  sdvo_version_minor: %d\n"
1668                       "  sdvo_inputs_mask: %d\n"
1669                       "  smooth_scaling: %d\n"
1670                       "  sharp_scaling: %d\n"
1671                       "  up_scaling: %d\n"
1672                       "  down_scaling: %d\n"
1673                       "  stall_support: %d\n"
1674                       "  output_flags: %d\n",
1675                       caps->vendor_id,
1676                       caps->device_id,
1677                       caps->device_rev_id,
1678                       caps->sdvo_version_major,
1679                       caps->sdvo_version_minor,
1680                       caps->sdvo_inputs_mask,
1681                       caps->smooth_scaling,
1682                       caps->sharp_scaling,
1683                       caps->up_scaling,
1684                       caps->down_scaling,
1685                       caps->stall_support,
1686                       caps->output_flags);
1687
1688         return true;
1689 }
1690
1691 static uint16_t intel_sdvo_get_hotplug_support(struct intel_sdvo *intel_sdvo)
1692 {
1693         struct drm_i915_private *dev_priv = to_i915(intel_sdvo->base.base.dev);
1694         uint16_t hotplug;
1695
1696         if (!I915_HAS_HOTPLUG(dev_priv))
1697                 return 0;
1698
1699         /*
1700          * HW Erratum: SDVO Hotplug is broken on all i945G chips, there's noise
1701          * on the line.
1702          */
1703         if (IS_I945G(dev_priv) || IS_I945GM(dev_priv))
1704                 return 0;
1705
1706         if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HOT_PLUG_SUPPORT,
1707                                         &hotplug, sizeof(hotplug)))
1708                 return 0;
1709
1710         return hotplug;
1711 }
1712
1713 static void intel_sdvo_enable_hotplug(struct intel_encoder *encoder)
1714 {
1715         struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
1716
1717         intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,
1718                              &intel_sdvo->hotplug_active, 2);
1719 }
1720
1721 static bool intel_sdvo_hotplug(struct intel_encoder *encoder,
1722                                struct intel_connector *connector)
1723 {
1724         intel_sdvo_enable_hotplug(encoder);
1725
1726         return intel_encoder_hotplug(encoder, connector);
1727 }
1728
1729 static bool
1730 intel_sdvo_multifunc_encoder(struct intel_sdvo *intel_sdvo)
1731 {
1732         /* Is there more than one type of output? */
1733         return hweight16(intel_sdvo->caps.output_flags) > 1;
1734 }
1735
1736 static struct edid *
1737 intel_sdvo_get_edid(struct drm_connector *connector)
1738 {
1739         struct intel_sdvo *sdvo = intel_attached_sdvo(connector);
1740         return drm_get_edid(connector, &sdvo->ddc);
1741 }
1742
1743 /* Mac mini hack -- use the same DDC as the analog connector */
1744 static struct edid *
1745 intel_sdvo_get_analog_edid(struct drm_connector *connector)
1746 {
1747         struct drm_i915_private *dev_priv = to_i915(connector->dev);
1748
1749         return drm_get_edid(connector,
1750                             intel_gmbus_get_adapter(dev_priv,
1751                                                     dev_priv->vbt.crt_ddc_pin));
1752 }
1753
1754 static enum drm_connector_status
1755 intel_sdvo_tmds_sink_detect(struct drm_connector *connector)
1756 {
1757         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1758         enum drm_connector_status status;
1759         struct edid *edid;
1760
1761         edid = intel_sdvo_get_edid(connector);
1762
1763         if (edid == NULL && intel_sdvo_multifunc_encoder(intel_sdvo)) {
1764                 u8 ddc, saved_ddc = intel_sdvo->ddc_bus;
1765
1766                 /*
1767                  * Don't use the 1 as the argument of DDC bus switch to get
1768                  * the EDID. It is used for SDVO SPD ROM.
1769                  */
1770                 for (ddc = intel_sdvo->ddc_bus >> 1; ddc > 1; ddc >>= 1) {
1771                         intel_sdvo->ddc_bus = ddc;
1772                         edid = intel_sdvo_get_edid(connector);
1773                         if (edid)
1774                                 break;
1775                 }
1776                 /*
1777                  * If we found the EDID on the other bus,
1778                  * assume that is the correct DDC bus.
1779                  */
1780                 if (edid == NULL)
1781                         intel_sdvo->ddc_bus = saved_ddc;
1782         }
1783
1784         /*
1785          * When there is no edid and no monitor is connected with VGA
1786          * port, try to use the CRT ddc to read the EDID for DVI-connector.
1787          */
1788         if (edid == NULL)
1789                 edid = intel_sdvo_get_analog_edid(connector);
1790
1791         status = connector_status_unknown;
1792         if (edid != NULL) {
1793                 /* DDC bus is shared, match EDID to connector type */
1794                 if (edid->input & DRM_EDID_INPUT_DIGITAL) {
1795                         status = connector_status_connected;
1796                         if (intel_sdvo->is_hdmi) {
1797                                 intel_sdvo->has_hdmi_monitor = drm_detect_hdmi_monitor(edid);
1798                                 intel_sdvo->has_hdmi_audio = drm_detect_monitor_audio(edid);
1799                                 intel_sdvo->rgb_quant_range_selectable =
1800                                         drm_rgb_quant_range_selectable(edid);
1801                         }
1802                 } else
1803                         status = connector_status_disconnected;
1804                 kfree(edid);
1805         }
1806
1807         return status;
1808 }
1809
1810 static bool
1811 intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo,
1812                                   struct edid *edid)
1813 {
1814         bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL);
1815         bool connector_is_digital = !!IS_DIGITAL(sdvo);
1816
1817         DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n",
1818                       connector_is_digital, monitor_is_digital);
1819         return connector_is_digital == monitor_is_digital;
1820 }
1821
1822 static enum drm_connector_status
1823 intel_sdvo_detect(struct drm_connector *connector, bool force)
1824 {
1825         uint16_t response;
1826         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1827         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1828         enum drm_connector_status ret;
1829
1830         DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
1831                       connector->base.id, connector->name);
1832
1833         if (!intel_sdvo_get_value(intel_sdvo,
1834                                   SDVO_CMD_GET_ATTACHED_DISPLAYS,
1835                                   &response, 2))
1836                 return connector_status_unknown;
1837
1838         DRM_DEBUG_KMS("SDVO response %d %d [%x]\n",
1839                       response & 0xff, response >> 8,
1840                       intel_sdvo_connector->output_flag);
1841
1842         if (response == 0)
1843                 return connector_status_disconnected;
1844
1845         intel_sdvo->attached_output = response;
1846
1847         intel_sdvo->has_hdmi_monitor = false;
1848         intel_sdvo->has_hdmi_audio = false;
1849         intel_sdvo->rgb_quant_range_selectable = false;
1850
1851         if ((intel_sdvo_connector->output_flag & response) == 0)
1852                 ret = connector_status_disconnected;
1853         else if (IS_TMDS(intel_sdvo_connector))
1854                 ret = intel_sdvo_tmds_sink_detect(connector);
1855         else {
1856                 struct edid *edid;
1857
1858                 /* if we have an edid check it matches the connection */
1859                 edid = intel_sdvo_get_edid(connector);
1860                 if (edid == NULL)
1861                         edid = intel_sdvo_get_analog_edid(connector);
1862                 if (edid != NULL) {
1863                         if (intel_sdvo_connector_matches_edid(intel_sdvo_connector,
1864                                                               edid))
1865                                 ret = connector_status_connected;
1866                         else
1867                                 ret = connector_status_disconnected;
1868
1869                         kfree(edid);
1870                 } else
1871                         ret = connector_status_connected;
1872         }
1873
1874         /* May update encoder flag for like clock for SDVO TV, etc.*/
1875         if (ret == connector_status_connected) {
1876                 intel_sdvo->is_tv = false;
1877                 intel_sdvo->is_lvds = false;
1878
1879                 if (response & SDVO_TV_MASK)
1880                         intel_sdvo->is_tv = true;
1881                 if (response & SDVO_LVDS_MASK)
1882                         intel_sdvo->is_lvds = intel_sdvo->sdvo_lvds_fixed_mode != NULL;
1883         }
1884
1885         return ret;
1886 }
1887
1888 static void intel_sdvo_get_ddc_modes(struct drm_connector *connector)
1889 {
1890         struct edid *edid;
1891
1892         DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
1893                       connector->base.id, connector->name);
1894
1895         /* set the bus switch and get the modes */
1896         edid = intel_sdvo_get_edid(connector);
1897
1898         /*
1899          * Mac mini hack.  On this device, the DVI-I connector shares one DDC
1900          * link between analog and digital outputs. So, if the regular SDVO
1901          * DDC fails, check to see if the analog output is disconnected, in
1902          * which case we'll look there for the digital DDC data.
1903          */
1904         if (edid == NULL)
1905                 edid = intel_sdvo_get_analog_edid(connector);
1906
1907         if (edid != NULL) {
1908                 if (intel_sdvo_connector_matches_edid(to_intel_sdvo_connector(connector),
1909                                                       edid)) {
1910                         drm_mode_connector_update_edid_property(connector, edid);
1911                         drm_add_edid_modes(connector, edid);
1912                 }
1913
1914                 kfree(edid);
1915         }
1916 }
1917
1918 /*
1919  * Set of SDVO TV modes.
1920  * Note!  This is in reply order (see loop in get_tv_modes).
1921  * XXX: all 60Hz refresh?
1922  */
1923 static const struct drm_display_mode sdvo_tv_modes[] = {
1924         { DRM_MODE("320x200", DRM_MODE_TYPE_DRIVER, 5815, 320, 321, 384,
1925                    416, 0, 200, 201, 232, 233, 0,
1926                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1927         { DRM_MODE("320x240", DRM_MODE_TYPE_DRIVER, 6814, 320, 321, 384,
1928                    416, 0, 240, 241, 272, 273, 0,
1929                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1930         { DRM_MODE("400x300", DRM_MODE_TYPE_DRIVER, 9910, 400, 401, 464,
1931                    496, 0, 300, 301, 332, 333, 0,
1932                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1933         { DRM_MODE("640x350", DRM_MODE_TYPE_DRIVER, 16913, 640, 641, 704,
1934                    736, 0, 350, 351, 382, 383, 0,
1935                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1936         { DRM_MODE("640x400", DRM_MODE_TYPE_DRIVER, 19121, 640, 641, 704,
1937                    736, 0, 400, 401, 432, 433, 0,
1938                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1939         { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 22654, 640, 641, 704,
1940                    736, 0, 480, 481, 512, 513, 0,
1941                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1942         { DRM_MODE("704x480", DRM_MODE_TYPE_DRIVER, 24624, 704, 705, 768,
1943                    800, 0, 480, 481, 512, 513, 0,
1944                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1945         { DRM_MODE("704x576", DRM_MODE_TYPE_DRIVER, 29232, 704, 705, 768,
1946                    800, 0, 576, 577, 608, 609, 0,
1947                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1948         { DRM_MODE("720x350", DRM_MODE_TYPE_DRIVER, 18751, 720, 721, 784,
1949                    816, 0, 350, 351, 382, 383, 0,
1950                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1951         { DRM_MODE("720x400", DRM_MODE_TYPE_DRIVER, 21199, 720, 721, 784,
1952                    816, 0, 400, 401, 432, 433, 0,
1953                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1954         { DRM_MODE("720x480", DRM_MODE_TYPE_DRIVER, 25116, 720, 721, 784,
1955                    816, 0, 480, 481, 512, 513, 0,
1956                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1957         { DRM_MODE("720x540", DRM_MODE_TYPE_DRIVER, 28054, 720, 721, 784,
1958                    816, 0, 540, 541, 572, 573, 0,
1959                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1960         { DRM_MODE("720x576", DRM_MODE_TYPE_DRIVER, 29816, 720, 721, 784,
1961                    816, 0, 576, 577, 608, 609, 0,
1962                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1963         { DRM_MODE("768x576", DRM_MODE_TYPE_DRIVER, 31570, 768, 769, 832,
1964                    864, 0, 576, 577, 608, 609, 0,
1965                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1966         { DRM_MODE("800x600", DRM_MODE_TYPE_DRIVER, 34030, 800, 801, 864,
1967                    896, 0, 600, 601, 632, 633, 0,
1968                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1969         { DRM_MODE("832x624", DRM_MODE_TYPE_DRIVER, 36581, 832, 833, 896,
1970                    928, 0, 624, 625, 656, 657, 0,
1971                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1972         { DRM_MODE("920x766", DRM_MODE_TYPE_DRIVER, 48707, 920, 921, 984,
1973                    1016, 0, 766, 767, 798, 799, 0,
1974                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1975         { DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 53827, 1024, 1025, 1088,
1976                    1120, 0, 768, 769, 800, 801, 0,
1977                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1978         { DRM_MODE("1280x1024", DRM_MODE_TYPE_DRIVER, 87265, 1280, 1281, 1344,
1979                    1376, 0, 1024, 1025, 1056, 1057, 0,
1980                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1981 };
1982
1983 static void intel_sdvo_get_tv_modes(struct drm_connector *connector)
1984 {
1985         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1986         const struct drm_connector_state *conn_state = connector->state;
1987         struct intel_sdvo_sdtv_resolution_request tv_res;
1988         uint32_t reply = 0, format_map = 0;
1989         int i;
1990
1991         DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
1992                       connector->base.id, connector->name);
1993
1994         /*
1995          * Read the list of supported input resolutions for the selected TV
1996          * format.
1997          */
1998         format_map = 1 << conn_state->tv.mode;
1999         memcpy(&tv_res, &format_map,
2000                min(sizeof(format_map), sizeof(struct intel_sdvo_sdtv_resolution_request)));
2001
2002         if (!intel_sdvo_set_target_output(intel_sdvo, intel_sdvo->attached_output))
2003                 return;
2004
2005         BUILD_BUG_ON(sizeof(tv_res) != 3);
2006         if (!intel_sdvo_write_cmd(intel_sdvo,
2007                                   SDVO_CMD_GET_SDTV_RESOLUTION_SUPPORT,
2008                                   &tv_res, sizeof(tv_res)))
2009                 return;
2010         if (!intel_sdvo_read_response(intel_sdvo, &reply, 3))
2011                 return;
2012
2013         for (i = 0; i < ARRAY_SIZE(sdvo_tv_modes); i++)
2014                 if (reply & (1 << i)) {
2015                         struct drm_display_mode *nmode;
2016                         nmode = drm_mode_duplicate(connector->dev,
2017                                                    &sdvo_tv_modes[i]);
2018                         if (nmode)
2019                                 drm_mode_probed_add(connector, nmode);
2020                 }
2021 }
2022
2023 static void intel_sdvo_get_lvds_modes(struct drm_connector *connector)
2024 {
2025         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
2026         struct drm_i915_private *dev_priv = to_i915(connector->dev);
2027         struct drm_display_mode *newmode;
2028
2029         DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
2030                       connector->base.id, connector->name);
2031
2032         /*
2033          * Fetch modes from VBT. For SDVO prefer the VBT mode since some
2034          * SDVO->LVDS transcoders can't cope with the EDID mode.
2035          */
2036         if (dev_priv->vbt.sdvo_lvds_vbt_mode != NULL) {
2037                 newmode = drm_mode_duplicate(connector->dev,
2038                                              dev_priv->vbt.sdvo_lvds_vbt_mode);
2039                 if (newmode != NULL) {
2040                         /* Guarantee the mode is preferred */
2041                         newmode->type = (DRM_MODE_TYPE_PREFERRED |
2042                                          DRM_MODE_TYPE_DRIVER);
2043                         drm_mode_probed_add(connector, newmode);
2044                 }
2045         }
2046
2047         /*
2048          * Attempt to get the mode list from DDC.
2049          * Assume that the preferred modes are
2050          * arranged in priority order.
2051          */
2052         intel_ddc_get_modes(connector, &intel_sdvo->ddc);
2053
2054         list_for_each_entry(newmode, &connector->probed_modes, head) {
2055                 if (newmode->type & DRM_MODE_TYPE_PREFERRED) {
2056                         intel_sdvo->sdvo_lvds_fixed_mode =
2057                                 drm_mode_duplicate(connector->dev, newmode);
2058
2059                         intel_sdvo->is_lvds = true;
2060                         break;
2061                 }
2062         }
2063 }
2064
2065 static int intel_sdvo_get_modes(struct drm_connector *connector)
2066 {
2067         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
2068
2069         if (IS_TV(intel_sdvo_connector))
2070                 intel_sdvo_get_tv_modes(connector);
2071         else if (IS_LVDS(intel_sdvo_connector))
2072                 intel_sdvo_get_lvds_modes(connector);
2073         else
2074                 intel_sdvo_get_ddc_modes(connector);
2075
2076         return !list_empty(&connector->probed_modes);
2077 }
2078
2079 static void intel_sdvo_destroy(struct drm_connector *connector)
2080 {
2081         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
2082
2083         drm_connector_cleanup(connector);
2084         kfree(intel_sdvo_connector);
2085 }
2086
2087 static int
2088 intel_sdvo_connector_atomic_get_property(struct drm_connector *connector,
2089                                          const struct drm_connector_state *state,
2090                                          struct drm_property *property,
2091                                          uint64_t *val)
2092 {
2093         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
2094         const struct intel_sdvo_connector_state *sdvo_state = to_intel_sdvo_connector_state((void *)state);
2095
2096         if (property == intel_sdvo_connector->tv_format) {
2097                 int i;
2098
2099                 for (i = 0; i < intel_sdvo_connector->format_supported_num; i++)
2100                         if (state->tv.mode == intel_sdvo_connector->tv_format_supported[i]) {
2101                                 *val = i;
2102
2103                                 return 0;
2104                         }
2105
2106                 WARN_ON(1);
2107                 *val = 0;
2108         } else if (property == intel_sdvo_connector->top ||
2109                    property == intel_sdvo_connector->bottom)
2110                 *val = intel_sdvo_connector->max_vscan - sdvo_state->tv.overscan_v;
2111         else if (property == intel_sdvo_connector->left ||
2112                  property == intel_sdvo_connector->right)
2113                 *val = intel_sdvo_connector->max_hscan - sdvo_state->tv.overscan_h;
2114         else if (property == intel_sdvo_connector->hpos)
2115                 *val = sdvo_state->tv.hpos;
2116         else if (property == intel_sdvo_connector->vpos)
2117                 *val = sdvo_state->tv.vpos;
2118         else if (property == intel_sdvo_connector->saturation)
2119                 *val = state->tv.saturation;
2120         else if (property == intel_sdvo_connector->contrast)
2121                 *val = state->tv.contrast;
2122         else if (property == intel_sdvo_connector->hue)
2123                 *val = state->tv.hue;
2124         else if (property == intel_sdvo_connector->brightness)
2125                 *val = state->tv.brightness;
2126         else if (property == intel_sdvo_connector->sharpness)
2127                 *val = sdvo_state->tv.sharpness;
2128         else if (property == intel_sdvo_connector->flicker_filter)
2129                 *val = sdvo_state->tv.flicker_filter;
2130         else if (property == intel_sdvo_connector->flicker_filter_2d)
2131                 *val = sdvo_state->tv.flicker_filter_2d;
2132         else if (property == intel_sdvo_connector->flicker_filter_adaptive)
2133                 *val = sdvo_state->tv.flicker_filter_adaptive;
2134         else if (property == intel_sdvo_connector->tv_chroma_filter)
2135                 *val = sdvo_state->tv.chroma_filter;
2136         else if (property == intel_sdvo_connector->tv_luma_filter)
2137                 *val = sdvo_state->tv.luma_filter;
2138         else if (property == intel_sdvo_connector->dot_crawl)
2139                 *val = sdvo_state->tv.dot_crawl;
2140         else
2141                 return intel_digital_connector_atomic_get_property(connector, state, property, val);
2142
2143         return 0;
2144 }
2145
2146 static int
2147 intel_sdvo_connector_atomic_set_property(struct drm_connector *connector,
2148                                          struct drm_connector_state *state,
2149                                          struct drm_property *property,
2150                                          uint64_t val)
2151 {
2152         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
2153         struct intel_sdvo_connector_state *sdvo_state = to_intel_sdvo_connector_state(state);
2154
2155         if (property == intel_sdvo_connector->tv_format) {
2156                 state->tv.mode = intel_sdvo_connector->tv_format_supported[val];
2157
2158                 if (state->crtc) {
2159                         struct drm_crtc_state *crtc_state =
2160                                 drm_atomic_get_new_crtc_state(state->state, state->crtc);
2161
2162                         crtc_state->connectors_changed = true;
2163                 }
2164         } else if (property == intel_sdvo_connector->top ||
2165                    property == intel_sdvo_connector->bottom)
2166                 /* Cannot set these independent from each other */
2167                 sdvo_state->tv.overscan_v = intel_sdvo_connector->max_vscan - val;
2168         else if (property == intel_sdvo_connector->left ||
2169                  property == intel_sdvo_connector->right)
2170                 /* Cannot set these independent from each other */
2171                 sdvo_state->tv.overscan_h = intel_sdvo_connector->max_hscan - val;
2172         else if (property == intel_sdvo_connector->hpos)
2173                 sdvo_state->tv.hpos = val;
2174         else if (property == intel_sdvo_connector->vpos)
2175                 sdvo_state->tv.vpos = val;
2176         else if (property == intel_sdvo_connector->saturation)
2177                 state->tv.saturation = val;
2178         else if (property == intel_sdvo_connector->contrast)
2179                 state->tv.contrast = val;
2180         else if (property == intel_sdvo_connector->hue)
2181                 state->tv.hue = val;
2182         else if (property == intel_sdvo_connector->brightness)
2183                 state->tv.brightness = val;
2184         else if (property == intel_sdvo_connector->sharpness)
2185                 sdvo_state->tv.sharpness = val;
2186         else if (property == intel_sdvo_connector->flicker_filter)
2187                 sdvo_state->tv.flicker_filter = val;
2188         else if (property == intel_sdvo_connector->flicker_filter_2d)
2189                 sdvo_state->tv.flicker_filter_2d = val;
2190         else if (property == intel_sdvo_connector->flicker_filter_adaptive)
2191                 sdvo_state->tv.flicker_filter_adaptive = val;
2192         else if (property == intel_sdvo_connector->tv_chroma_filter)
2193                 sdvo_state->tv.chroma_filter = val;
2194         else if (property == intel_sdvo_connector->tv_luma_filter)
2195                 sdvo_state->tv.luma_filter = val;
2196         else if (property == intel_sdvo_connector->dot_crawl)
2197                 sdvo_state->tv.dot_crawl = val;
2198         else
2199                 return intel_digital_connector_atomic_set_property(connector, state, property, val);
2200
2201         return 0;
2202 }
2203
2204 static int
2205 intel_sdvo_connector_register(struct drm_connector *connector)
2206 {
2207         struct intel_sdvo *sdvo = intel_attached_sdvo(connector);
2208         int ret;
2209
2210         ret = intel_connector_register(connector);
2211         if (ret)
2212                 return ret;
2213
2214         return sysfs_create_link(&connector->kdev->kobj,
2215                                  &sdvo->ddc.dev.kobj,
2216                                  sdvo->ddc.dev.kobj.name);
2217 }
2218
2219 static void
2220 intel_sdvo_connector_unregister(struct drm_connector *connector)
2221 {
2222         struct intel_sdvo *sdvo = intel_attached_sdvo(connector);
2223
2224         sysfs_remove_link(&connector->kdev->kobj,
2225                           sdvo->ddc.dev.kobj.name);
2226         intel_connector_unregister(connector);
2227 }
2228
2229 static struct drm_connector_state *
2230 intel_sdvo_connector_duplicate_state(struct drm_connector *connector)
2231 {
2232         struct intel_sdvo_connector_state *state;
2233
2234         state = kmemdup(connector->state, sizeof(*state), GFP_KERNEL);
2235         if (!state)
2236                 return NULL;
2237
2238         __drm_atomic_helper_connector_duplicate_state(connector, &state->base.base);
2239         return &state->base.base;
2240 }
2241
2242 static const struct drm_connector_funcs intel_sdvo_connector_funcs = {
2243         .detect = intel_sdvo_detect,
2244         .fill_modes = drm_helper_probe_single_connector_modes,
2245         .atomic_get_property = intel_sdvo_connector_atomic_get_property,
2246         .atomic_set_property = intel_sdvo_connector_atomic_set_property,
2247         .late_register = intel_sdvo_connector_register,
2248         .early_unregister = intel_sdvo_connector_unregister,
2249         .destroy = intel_sdvo_destroy,
2250         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
2251         .atomic_duplicate_state = intel_sdvo_connector_duplicate_state,
2252 };
2253
2254 static int intel_sdvo_atomic_check(struct drm_connector *conn,
2255                                    struct drm_connector_state *new_conn_state)
2256 {
2257         struct drm_atomic_state *state = new_conn_state->state;
2258         struct drm_connector_state *old_conn_state =
2259                 drm_atomic_get_old_connector_state(state, conn);
2260         struct intel_sdvo_connector_state *old_state =
2261                 to_intel_sdvo_connector_state(old_conn_state);
2262         struct intel_sdvo_connector_state *new_state =
2263                 to_intel_sdvo_connector_state(new_conn_state);
2264
2265         if (new_conn_state->crtc &&
2266             (memcmp(&old_state->tv, &new_state->tv, sizeof(old_state->tv)) ||
2267              memcmp(&old_conn_state->tv, &new_conn_state->tv, sizeof(old_conn_state->tv)))) {
2268                 struct drm_crtc_state *crtc_state =
2269                         drm_atomic_get_new_crtc_state(new_conn_state->state,
2270                                                       new_conn_state->crtc);
2271
2272                 crtc_state->connectors_changed = true;
2273         }
2274
2275         return intel_digital_connector_atomic_check(conn, new_conn_state);
2276 }
2277
2278 static const struct drm_connector_helper_funcs intel_sdvo_connector_helper_funcs = {
2279         .get_modes = intel_sdvo_get_modes,
2280         .mode_valid = intel_sdvo_mode_valid,
2281         .atomic_check = intel_sdvo_atomic_check,
2282 };
2283
2284 static void intel_sdvo_enc_destroy(struct drm_encoder *encoder)
2285 {
2286         struct intel_sdvo *intel_sdvo = to_sdvo(to_intel_encoder(encoder));
2287
2288         if (intel_sdvo->sdvo_lvds_fixed_mode != NULL)
2289                 drm_mode_destroy(encoder->dev,
2290                                  intel_sdvo->sdvo_lvds_fixed_mode);
2291
2292         i2c_del_adapter(&intel_sdvo->ddc);
2293         intel_encoder_destroy(encoder);
2294 }
2295
2296 static const struct drm_encoder_funcs intel_sdvo_enc_funcs = {
2297         .destroy = intel_sdvo_enc_destroy,
2298 };
2299
2300 static void
2301 intel_sdvo_guess_ddc_bus(struct intel_sdvo *sdvo)
2302 {
2303         uint16_t mask = 0;
2304         unsigned int num_bits;
2305
2306         /*
2307          * Make a mask of outputs less than or equal to our own priority in the
2308          * list.
2309          */
2310         switch (sdvo->controlled_output) {
2311         case SDVO_OUTPUT_LVDS1:
2312                 mask |= SDVO_OUTPUT_LVDS1;
2313         case SDVO_OUTPUT_LVDS0:
2314                 mask |= SDVO_OUTPUT_LVDS0;
2315         case SDVO_OUTPUT_TMDS1:
2316                 mask |= SDVO_OUTPUT_TMDS1;
2317         case SDVO_OUTPUT_TMDS0:
2318                 mask |= SDVO_OUTPUT_TMDS0;
2319         case SDVO_OUTPUT_RGB1:
2320                 mask |= SDVO_OUTPUT_RGB1;
2321         case SDVO_OUTPUT_RGB0:
2322                 mask |= SDVO_OUTPUT_RGB0;
2323                 break;
2324         }
2325
2326         /* Count bits to find what number we are in the priority list. */
2327         mask &= sdvo->caps.output_flags;
2328         num_bits = hweight16(mask);
2329         /* If more than 3 outputs, default to DDC bus 3 for now. */
2330         if (num_bits > 3)
2331                 num_bits = 3;
2332
2333         /* Corresponds to SDVO_CONTROL_BUS_DDCx */
2334         sdvo->ddc_bus = 1 << num_bits;
2335 }
2336
2337 /*
2338  * Choose the appropriate DDC bus for control bus switch command for this
2339  * SDVO output based on the controlled output.
2340  *
2341  * DDC bus number assignment is in a priority order of RGB outputs, then TMDS
2342  * outputs, then LVDS outputs.
2343  */
2344 static void
2345 intel_sdvo_select_ddc_bus(struct drm_i915_private *dev_priv,
2346                           struct intel_sdvo *sdvo)
2347 {
2348         struct sdvo_device_mapping *mapping;
2349
2350         if (sdvo->port == PORT_B)
2351                 mapping = &dev_priv->vbt.sdvo_mappings[0];
2352         else
2353                 mapping = &dev_priv->vbt.sdvo_mappings[1];
2354
2355         if (mapping->initialized)
2356                 sdvo->ddc_bus = 1 << ((mapping->ddc_pin & 0xf0) >> 4);
2357         else
2358                 intel_sdvo_guess_ddc_bus(sdvo);
2359 }
2360
2361 static void
2362 intel_sdvo_select_i2c_bus(struct drm_i915_private *dev_priv,
2363                           struct intel_sdvo *sdvo)
2364 {
2365         struct sdvo_device_mapping *mapping;
2366         u8 pin;
2367
2368         if (sdvo->port == PORT_B)
2369                 mapping = &dev_priv->vbt.sdvo_mappings[0];
2370         else
2371                 mapping = &dev_priv->vbt.sdvo_mappings[1];
2372
2373         if (mapping->initialized &&
2374             intel_gmbus_is_valid_pin(dev_priv, mapping->i2c_pin))
2375                 pin = mapping->i2c_pin;
2376         else
2377                 pin = GMBUS_PIN_DPB;
2378
2379         sdvo->i2c = intel_gmbus_get_adapter(dev_priv, pin);
2380
2381         /*
2382          * With gmbus we should be able to drive sdvo i2c at 2MHz, but somehow
2383          * our code totally fails once we start using gmbus. Hence fall back to
2384          * bit banging for now.
2385          */
2386         intel_gmbus_force_bit(sdvo->i2c, true);
2387 }
2388
2389 /* undo any changes intel_sdvo_select_i2c_bus() did to sdvo->i2c */
2390 static void
2391 intel_sdvo_unselect_i2c_bus(struct intel_sdvo *sdvo)
2392 {
2393         intel_gmbus_force_bit(sdvo->i2c, false);
2394 }
2395
2396 static bool
2397 intel_sdvo_is_hdmi_connector(struct intel_sdvo *intel_sdvo, int device)
2398 {
2399         return intel_sdvo_check_supp_encode(intel_sdvo);
2400 }
2401
2402 static u8
2403 intel_sdvo_get_slave_addr(struct drm_i915_private *dev_priv,
2404                           struct intel_sdvo *sdvo)
2405 {
2406         struct sdvo_device_mapping *my_mapping, *other_mapping;
2407
2408         if (sdvo->port == PORT_B) {
2409                 my_mapping = &dev_priv->vbt.sdvo_mappings[0];
2410                 other_mapping = &dev_priv->vbt.sdvo_mappings[1];
2411         } else {
2412                 my_mapping = &dev_priv->vbt.sdvo_mappings[1];
2413                 other_mapping = &dev_priv->vbt.sdvo_mappings[0];
2414         }
2415
2416         /* If the BIOS described our SDVO device, take advantage of it. */
2417         if (my_mapping->slave_addr)
2418                 return my_mapping->slave_addr;
2419
2420         /*
2421          * If the BIOS only described a different SDVO device, use the
2422          * address that it isn't using.
2423          */
2424         if (other_mapping->slave_addr) {
2425                 if (other_mapping->slave_addr == 0x70)
2426                         return 0x72;
2427                 else
2428                         return 0x70;
2429         }
2430
2431         /*
2432          * No SDVO device info is found for another DVO port,
2433          * so use mapping assumption we had before BIOS parsing.
2434          */
2435         if (sdvo->port == PORT_B)
2436                 return 0x70;
2437         else
2438                 return 0x72;
2439 }
2440
2441 static int
2442 intel_sdvo_connector_init(struct intel_sdvo_connector *connector,
2443                           struct intel_sdvo *encoder)
2444 {
2445         struct drm_connector *drm_connector;
2446         int ret;
2447
2448         drm_connector = &connector->base.base;
2449         ret = drm_connector_init(encoder->base.base.dev,
2450                            drm_connector,
2451                            &intel_sdvo_connector_funcs,
2452                            connector->base.base.connector_type);
2453         if (ret < 0)
2454                 return ret;
2455
2456         drm_connector_helper_add(drm_connector,
2457                                  &intel_sdvo_connector_helper_funcs);
2458
2459         connector->base.base.interlace_allowed = 1;
2460         connector->base.base.doublescan_allowed = 0;
2461         connector->base.base.display_info.subpixel_order = SubPixelHorizontalRGB;
2462         connector->base.get_hw_state = intel_sdvo_connector_get_hw_state;
2463
2464         intel_connector_attach_encoder(&connector->base, &encoder->base);
2465
2466         return 0;
2467 }
2468
2469 static void
2470 intel_sdvo_add_hdmi_properties(struct intel_sdvo *intel_sdvo,
2471                                struct intel_sdvo_connector *connector)
2472 {
2473         struct drm_i915_private *dev_priv = to_i915(connector->base.base.dev);
2474
2475         intel_attach_force_audio_property(&connector->base.base);
2476         if (INTEL_GEN(dev_priv) >= 4 && IS_MOBILE(dev_priv)) {
2477                 intel_attach_broadcast_rgb_property(&connector->base.base);
2478         }
2479         intel_attach_aspect_ratio_property(&connector->base.base);
2480         connector->base.base.state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
2481 }
2482
2483 static struct intel_sdvo_connector *intel_sdvo_connector_alloc(void)
2484 {
2485         struct intel_sdvo_connector *sdvo_connector;
2486         struct intel_sdvo_connector_state *conn_state;
2487
2488         sdvo_connector = kzalloc(sizeof(*sdvo_connector), GFP_KERNEL);
2489         if (!sdvo_connector)
2490                 return NULL;
2491
2492         conn_state = kzalloc(sizeof(*conn_state), GFP_KERNEL);
2493         if (!conn_state) {
2494                 kfree(sdvo_connector);
2495                 return NULL;
2496         }
2497
2498         __drm_atomic_helper_connector_reset(&sdvo_connector->base.base,
2499                                             &conn_state->base.base);
2500
2501         return sdvo_connector;
2502 }
2503
2504 static bool
2505 intel_sdvo_dvi_init(struct intel_sdvo *intel_sdvo, int device)
2506 {
2507         struct drm_encoder *encoder = &intel_sdvo->base.base;
2508         struct drm_i915_private *dev_priv = to_i915(encoder->dev);
2509         struct drm_connector *connector;
2510         struct intel_encoder *intel_encoder = to_intel_encoder(encoder);
2511         struct intel_connector *intel_connector;
2512         struct intel_sdvo_connector *intel_sdvo_connector;
2513
2514         DRM_DEBUG_KMS("initialising DVI device %d\n", device);
2515
2516         intel_sdvo_connector = intel_sdvo_connector_alloc();
2517         if (!intel_sdvo_connector)
2518                 return false;
2519
2520         if (device == 0) {
2521                 intel_sdvo->controlled_output |= SDVO_OUTPUT_TMDS0;
2522                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_TMDS0;
2523         } else if (device == 1) {
2524                 intel_sdvo->controlled_output |= SDVO_OUTPUT_TMDS1;
2525                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_TMDS1;
2526         }
2527
2528         intel_connector = &intel_sdvo_connector->base;
2529         connector = &intel_connector->base;
2530         if (intel_sdvo_get_hotplug_support(intel_sdvo) &
2531                 intel_sdvo_connector->output_flag) {
2532                 intel_sdvo->hotplug_active |= intel_sdvo_connector->output_flag;
2533                 /*
2534                  * Some SDVO devices have one-shot hotplug interrupts.
2535                  * Ensure that they get re-enabled when an interrupt happens.
2536                  */
2537                 intel_encoder->hotplug = intel_sdvo_hotplug;
2538                 intel_sdvo_enable_hotplug(intel_encoder);
2539         } else {
2540                 intel_connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
2541         }
2542         encoder->encoder_type = DRM_MODE_ENCODER_TMDS;
2543         connector->connector_type = DRM_MODE_CONNECTOR_DVID;
2544
2545         /* gen3 doesn't do the hdmi bits in the SDVO register */
2546         if (INTEL_GEN(dev_priv) >= 4 &&
2547             intel_sdvo_is_hdmi_connector(intel_sdvo, device)) {
2548                 connector->connector_type = DRM_MODE_CONNECTOR_HDMIA;
2549                 intel_sdvo->is_hdmi = true;
2550         }
2551
2552         if (intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo) < 0) {
2553                 kfree(intel_sdvo_connector);
2554                 return false;
2555         }
2556
2557         if (intel_sdvo->is_hdmi)
2558                 intel_sdvo_add_hdmi_properties(intel_sdvo, intel_sdvo_connector);
2559
2560         return true;
2561 }
2562
2563 static bool
2564 intel_sdvo_tv_init(struct intel_sdvo *intel_sdvo, int type)
2565 {
2566         struct drm_encoder *encoder = &intel_sdvo->base.base;
2567         struct drm_connector *connector;
2568         struct intel_connector *intel_connector;
2569         struct intel_sdvo_connector *intel_sdvo_connector;
2570
2571         DRM_DEBUG_KMS("initialising TV type %d\n", type);
2572
2573         intel_sdvo_connector = intel_sdvo_connector_alloc();
2574         if (!intel_sdvo_connector)
2575                 return false;
2576
2577         intel_connector = &intel_sdvo_connector->base;
2578         connector = &intel_connector->base;
2579         encoder->encoder_type = DRM_MODE_ENCODER_TVDAC;
2580         connector->connector_type = DRM_MODE_CONNECTOR_SVIDEO;
2581
2582         intel_sdvo->controlled_output |= type;
2583         intel_sdvo_connector->output_flag = type;
2584
2585         intel_sdvo->is_tv = true;
2586
2587         if (intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo) < 0) {
2588                 kfree(intel_sdvo_connector);
2589                 return false;
2590         }
2591
2592         if (!intel_sdvo_tv_create_property(intel_sdvo, intel_sdvo_connector, type))
2593                 goto err;
2594
2595         if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
2596                 goto err;
2597
2598         return true;
2599
2600 err:
2601         intel_sdvo_destroy(connector);
2602         return false;
2603 }
2604
2605 static bool
2606 intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device)
2607 {
2608         struct drm_encoder *encoder = &intel_sdvo->base.base;
2609         struct drm_connector *connector;
2610         struct intel_connector *intel_connector;
2611         struct intel_sdvo_connector *intel_sdvo_connector;
2612
2613         DRM_DEBUG_KMS("initialising analog device %d\n", device);
2614
2615         intel_sdvo_connector = intel_sdvo_connector_alloc();
2616         if (!intel_sdvo_connector)
2617                 return false;
2618
2619         intel_connector = &intel_sdvo_connector->base;
2620         connector = &intel_connector->base;
2621         intel_connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2622         encoder->encoder_type = DRM_MODE_ENCODER_DAC;
2623         connector->connector_type = DRM_MODE_CONNECTOR_VGA;
2624
2625         if (device == 0) {
2626                 intel_sdvo->controlled_output |= SDVO_OUTPUT_RGB0;
2627                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_RGB0;
2628         } else if (device == 1) {
2629                 intel_sdvo->controlled_output |= SDVO_OUTPUT_RGB1;
2630                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_RGB1;
2631         }
2632
2633         if (intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo) < 0) {
2634                 kfree(intel_sdvo_connector);
2635                 return false;
2636         }
2637
2638         return true;
2639 }
2640
2641 static bool
2642 intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
2643 {
2644         struct drm_encoder *encoder = &intel_sdvo->base.base;
2645         struct drm_connector *connector;
2646         struct intel_connector *intel_connector;
2647         struct intel_sdvo_connector *intel_sdvo_connector;
2648
2649         DRM_DEBUG_KMS("initialising LVDS device %d\n", device);
2650
2651         intel_sdvo_connector = intel_sdvo_connector_alloc();
2652         if (!intel_sdvo_connector)
2653                 return false;
2654
2655         intel_connector = &intel_sdvo_connector->base;
2656         connector = &intel_connector->base;
2657         encoder->encoder_type = DRM_MODE_ENCODER_LVDS;
2658         connector->connector_type = DRM_MODE_CONNECTOR_LVDS;
2659
2660         if (device == 0) {
2661                 intel_sdvo->controlled_output |= SDVO_OUTPUT_LVDS0;
2662                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_LVDS0;
2663         } else if (device == 1) {
2664                 intel_sdvo->controlled_output |= SDVO_OUTPUT_LVDS1;
2665                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_LVDS1;
2666         }
2667
2668         if (intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo) < 0) {
2669                 kfree(intel_sdvo_connector);
2670                 return false;
2671         }
2672
2673         if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
2674                 goto err;
2675
2676         return true;
2677
2678 err:
2679         intel_sdvo_destroy(connector);
2680         return false;
2681 }
2682
2683 static bool
2684 intel_sdvo_output_setup(struct intel_sdvo *intel_sdvo, uint16_t flags)
2685 {
2686         intel_sdvo->is_tv = false;
2687         intel_sdvo->is_lvds = false;
2688
2689         /* SDVO requires XXX1 function may not exist unless it has XXX0 function.*/
2690
2691         if (flags & SDVO_OUTPUT_TMDS0)
2692                 if (!intel_sdvo_dvi_init(intel_sdvo, 0))
2693                         return false;
2694
2695         if ((flags & SDVO_TMDS_MASK) == SDVO_TMDS_MASK)
2696                 if (!intel_sdvo_dvi_init(intel_sdvo, 1))
2697                         return false;
2698
2699         /* TV has no XXX1 function block */
2700         if (flags & SDVO_OUTPUT_SVID0)
2701                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_SVID0))
2702                         return false;
2703
2704         if (flags & SDVO_OUTPUT_CVBS0)
2705                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_CVBS0))
2706                         return false;
2707
2708         if (flags & SDVO_OUTPUT_YPRPB0)
2709                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_YPRPB0))
2710                         return false;
2711
2712         if (flags & SDVO_OUTPUT_RGB0)
2713                 if (!intel_sdvo_analog_init(intel_sdvo, 0))
2714                         return false;
2715
2716         if ((flags & SDVO_RGB_MASK) == SDVO_RGB_MASK)
2717                 if (!intel_sdvo_analog_init(intel_sdvo, 1))
2718                         return false;
2719
2720         if (flags & SDVO_OUTPUT_LVDS0)
2721                 if (!intel_sdvo_lvds_init(intel_sdvo, 0))
2722                         return false;
2723
2724         if ((flags & SDVO_LVDS_MASK) == SDVO_LVDS_MASK)
2725                 if (!intel_sdvo_lvds_init(intel_sdvo, 1))
2726                         return false;
2727
2728         if ((flags & SDVO_OUTPUT_MASK) == 0) {
2729                 unsigned char bytes[2];
2730
2731                 intel_sdvo->controlled_output = 0;
2732                 memcpy(bytes, &intel_sdvo->caps.output_flags, 2);
2733                 DRM_DEBUG_KMS("%s: Unknown SDVO output type (0x%02x%02x)\n",
2734                               SDVO_NAME(intel_sdvo),
2735                               bytes[0], bytes[1]);
2736                 return false;
2737         }
2738         intel_sdvo->base.crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
2739
2740         return true;
2741 }
2742
2743 static void intel_sdvo_output_cleanup(struct intel_sdvo *intel_sdvo)
2744 {
2745         struct drm_device *dev = intel_sdvo->base.base.dev;
2746         struct drm_connector *connector, *tmp;
2747
2748         list_for_each_entry_safe(connector, tmp,
2749                                  &dev->mode_config.connector_list, head) {
2750                 if (intel_attached_encoder(connector) == &intel_sdvo->base) {
2751                         drm_connector_unregister(connector);
2752                         intel_sdvo_destroy(connector);
2753                 }
2754         }
2755 }
2756
2757 static bool intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo,
2758                                           struct intel_sdvo_connector *intel_sdvo_connector,
2759                                           int type)
2760 {
2761         struct drm_device *dev = intel_sdvo->base.base.dev;
2762         struct intel_sdvo_tv_format format;
2763         uint32_t format_map, i;
2764
2765         if (!intel_sdvo_set_target_output(intel_sdvo, type))
2766                 return false;
2767
2768         BUILD_BUG_ON(sizeof(format) != 6);
2769         if (!intel_sdvo_get_value(intel_sdvo,
2770                                   SDVO_CMD_GET_SUPPORTED_TV_FORMATS,
2771                                   &format, sizeof(format)))
2772                 return false;
2773
2774         memcpy(&format_map, &format, min(sizeof(format_map), sizeof(format)));
2775
2776         if (format_map == 0)
2777                 return false;
2778
2779         intel_sdvo_connector->format_supported_num = 0;
2780         for (i = 0 ; i < TV_FORMAT_NUM; i++)
2781                 if (format_map & (1 << i))
2782                         intel_sdvo_connector->tv_format_supported[intel_sdvo_connector->format_supported_num++] = i;
2783
2784
2785         intel_sdvo_connector->tv_format =
2786                         drm_property_create(dev, DRM_MODE_PROP_ENUM,
2787                                             "mode", intel_sdvo_connector->format_supported_num);
2788         if (!intel_sdvo_connector->tv_format)
2789                 return false;
2790
2791         for (i = 0; i < intel_sdvo_connector->format_supported_num; i++)
2792                 drm_property_add_enum(intel_sdvo_connector->tv_format, i,
2793                                       tv_format_names[intel_sdvo_connector->tv_format_supported[i]]);
2794
2795         intel_sdvo_connector->base.base.state->tv.mode = intel_sdvo_connector->tv_format_supported[0];
2796         drm_object_attach_property(&intel_sdvo_connector->base.base.base,
2797                                    intel_sdvo_connector->tv_format, 0);
2798         return true;
2799
2800 }
2801
2802 #define _ENHANCEMENT(state_assignment, name, NAME) do { \
2803         if (enhancements.name) { \
2804                 if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_MAX_##NAME, &data_value, 4) || \
2805                     !intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_##NAME, &response, 2)) \
2806                         return false; \
2807                 intel_sdvo_connector->name = \
2808                         drm_property_create_range(dev, 0, #name, 0, data_value[0]); \
2809                 if (!intel_sdvo_connector->name) return false; \
2810                 state_assignment = response; \
2811                 drm_object_attach_property(&connector->base, \
2812                                            intel_sdvo_connector->name, 0); \
2813                 DRM_DEBUG_KMS(#name ": max %d, default %d, current %d\n", \
2814                               data_value[0], data_value[1], response); \
2815         } \
2816 } while (0)
2817
2818 #define ENHANCEMENT(state, name, NAME) _ENHANCEMENT((state)->name, name, NAME)
2819
2820 static bool
2821 intel_sdvo_create_enhance_property_tv(struct intel_sdvo *intel_sdvo,
2822                                       struct intel_sdvo_connector *intel_sdvo_connector,
2823                                       struct intel_sdvo_enhancements_reply enhancements)
2824 {
2825         struct drm_device *dev = intel_sdvo->base.base.dev;
2826         struct drm_connector *connector = &intel_sdvo_connector->base.base;
2827         struct drm_connector_state *conn_state = connector->state;
2828         struct intel_sdvo_connector_state *sdvo_state =
2829                 to_intel_sdvo_connector_state(conn_state);
2830         uint16_t response, data_value[2];
2831
2832         /* when horizontal overscan is supported, Add the left/right property */
2833         if (enhancements.overscan_h) {
2834                 if (!intel_sdvo_get_value(intel_sdvo,
2835                                           SDVO_CMD_GET_MAX_OVERSCAN_H,
2836                                           &data_value, 4))
2837                         return false;
2838
2839                 if (!intel_sdvo_get_value(intel_sdvo,
2840                                           SDVO_CMD_GET_OVERSCAN_H,
2841                                           &response, 2))
2842                         return false;
2843
2844                 sdvo_state->tv.overscan_h = response;
2845
2846                 intel_sdvo_connector->max_hscan = data_value[0];
2847                 intel_sdvo_connector->left =
2848                         drm_property_create_range(dev, 0, "left_margin", 0, data_value[0]);
2849                 if (!intel_sdvo_connector->left)
2850                         return false;
2851
2852                 drm_object_attach_property(&connector->base,
2853                                            intel_sdvo_connector->left, 0);
2854
2855                 intel_sdvo_connector->right =
2856                         drm_property_create_range(dev, 0, "right_margin", 0, data_value[0]);
2857                 if (!intel_sdvo_connector->right)
2858                         return false;
2859
2860                 drm_object_attach_property(&connector->base,
2861                                               intel_sdvo_connector->right, 0);
2862                 DRM_DEBUG_KMS("h_overscan: max %d, "
2863                               "default %d, current %d\n",
2864                               data_value[0], data_value[1], response);
2865         }
2866
2867         if (enhancements.overscan_v) {
2868                 if (!intel_sdvo_get_value(intel_sdvo,
2869                                           SDVO_CMD_GET_MAX_OVERSCAN_V,
2870                                           &data_value, 4))
2871                         return false;
2872
2873                 if (!intel_sdvo_get_value(intel_sdvo,
2874                                           SDVO_CMD_GET_OVERSCAN_V,
2875                                           &response, 2))
2876                         return false;
2877
2878                 sdvo_state->tv.overscan_v = response;
2879
2880                 intel_sdvo_connector->max_vscan = data_value[0];
2881                 intel_sdvo_connector->top =
2882                         drm_property_create_range(dev, 0,
2883                                             "top_margin", 0, data_value[0]);
2884                 if (!intel_sdvo_connector->top)
2885                         return false;
2886
2887                 drm_object_attach_property(&connector->base,
2888                                            intel_sdvo_connector->top, 0);
2889
2890                 intel_sdvo_connector->bottom =
2891                         drm_property_create_range(dev, 0,
2892                                             "bottom_margin", 0, data_value[0]);
2893                 if (!intel_sdvo_connector->bottom)
2894                         return false;
2895
2896                 drm_object_attach_property(&connector->base,
2897                                               intel_sdvo_connector->bottom, 0);
2898                 DRM_DEBUG_KMS("v_overscan: max %d, "
2899                               "default %d, current %d\n",
2900                               data_value[0], data_value[1], response);
2901         }
2902
2903         ENHANCEMENT(&sdvo_state->tv, hpos, HPOS);
2904         ENHANCEMENT(&sdvo_state->tv, vpos, VPOS);
2905         ENHANCEMENT(&conn_state->tv, saturation, SATURATION);
2906         ENHANCEMENT(&conn_state->tv, contrast, CONTRAST);
2907         ENHANCEMENT(&conn_state->tv, hue, HUE);
2908         ENHANCEMENT(&conn_state->tv, brightness, BRIGHTNESS);
2909         ENHANCEMENT(&sdvo_state->tv, sharpness, SHARPNESS);
2910         ENHANCEMENT(&sdvo_state->tv, flicker_filter, FLICKER_FILTER);
2911         ENHANCEMENT(&sdvo_state->tv, flicker_filter_adaptive, FLICKER_FILTER_ADAPTIVE);
2912         ENHANCEMENT(&sdvo_state->tv, flicker_filter_2d, FLICKER_FILTER_2D);
2913         _ENHANCEMENT(sdvo_state->tv.chroma_filter, tv_chroma_filter, TV_CHROMA_FILTER);
2914         _ENHANCEMENT(sdvo_state->tv.luma_filter, tv_luma_filter, TV_LUMA_FILTER);
2915
2916         if (enhancements.dot_crawl) {
2917                 if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_DOT_CRAWL, &response, 2))
2918                         return false;
2919
2920                 sdvo_state->tv.dot_crawl = response & 0x1;
2921                 intel_sdvo_connector->dot_crawl =
2922                         drm_property_create_range(dev, 0, "dot_crawl", 0, 1);
2923                 if (!intel_sdvo_connector->dot_crawl)
2924                         return false;
2925
2926                 drm_object_attach_property(&connector->base,
2927                                            intel_sdvo_connector->dot_crawl, 0);
2928                 DRM_DEBUG_KMS("dot crawl: current %d\n", response);
2929         }
2930
2931         return true;
2932 }
2933
2934 static bool
2935 intel_sdvo_create_enhance_property_lvds(struct intel_sdvo *intel_sdvo,
2936                                         struct intel_sdvo_connector *intel_sdvo_connector,
2937                                         struct intel_sdvo_enhancements_reply enhancements)
2938 {
2939         struct drm_device *dev = intel_sdvo->base.base.dev;
2940         struct drm_connector *connector = &intel_sdvo_connector->base.base;
2941         uint16_t response, data_value[2];
2942
2943         ENHANCEMENT(&connector->state->tv, brightness, BRIGHTNESS);
2944
2945         return true;
2946 }
2947 #undef ENHANCEMENT
2948 #undef _ENHANCEMENT
2949
2950 static bool intel_sdvo_create_enhance_property(struct intel_sdvo *intel_sdvo,
2951                                                struct intel_sdvo_connector *intel_sdvo_connector)
2952 {
2953         union {
2954                 struct intel_sdvo_enhancements_reply reply;
2955                 uint16_t response;
2956         } enhancements;
2957
2958         BUILD_BUG_ON(sizeof(enhancements) != 2);
2959
2960         if (!intel_sdvo_get_value(intel_sdvo,
2961                                   SDVO_CMD_GET_SUPPORTED_ENHANCEMENTS,
2962                                   &enhancements, sizeof(enhancements)) ||
2963             enhancements.response == 0) {
2964                 DRM_DEBUG_KMS("No enhancement is supported\n");
2965                 return true;
2966         }
2967
2968         if (IS_TV(intel_sdvo_connector))
2969                 return intel_sdvo_create_enhance_property_tv(intel_sdvo, intel_sdvo_connector, enhancements.reply);
2970         else if (IS_LVDS(intel_sdvo_connector))
2971                 return intel_sdvo_create_enhance_property_lvds(intel_sdvo, intel_sdvo_connector, enhancements.reply);
2972         else
2973                 return true;
2974 }
2975
2976 static int intel_sdvo_ddc_proxy_xfer(struct i2c_adapter *adapter,
2977                                      struct i2c_msg *msgs,
2978                                      int num)
2979 {
2980         struct intel_sdvo *sdvo = adapter->algo_data;
2981
2982         if (!__intel_sdvo_set_control_bus_switch(sdvo, sdvo->ddc_bus))
2983                 return -EIO;
2984
2985         return sdvo->i2c->algo->master_xfer(sdvo->i2c, msgs, num);
2986 }
2987
2988 static u32 intel_sdvo_ddc_proxy_func(struct i2c_adapter *adapter)
2989 {
2990         struct intel_sdvo *sdvo = adapter->algo_data;
2991         return sdvo->i2c->algo->functionality(sdvo->i2c);
2992 }
2993
2994 static const struct i2c_algorithm intel_sdvo_ddc_proxy = {
2995         .master_xfer    = intel_sdvo_ddc_proxy_xfer,
2996         .functionality  = intel_sdvo_ddc_proxy_func
2997 };
2998
2999 static void proxy_lock_bus(struct i2c_adapter *adapter,
3000                            unsigned int flags)
3001 {
3002         struct intel_sdvo *sdvo = adapter->algo_data;
3003         sdvo->i2c->lock_ops->lock_bus(sdvo->i2c, flags);
3004 }
3005
3006 static int proxy_trylock_bus(struct i2c_adapter *adapter,
3007                              unsigned int flags)
3008 {
3009         struct intel_sdvo *sdvo = adapter->algo_data;
3010         return sdvo->i2c->lock_ops->trylock_bus(sdvo->i2c, flags);
3011 }
3012
3013 static void proxy_unlock_bus(struct i2c_adapter *adapter,
3014                              unsigned int flags)
3015 {
3016         struct intel_sdvo *sdvo = adapter->algo_data;
3017         sdvo->i2c->lock_ops->unlock_bus(sdvo->i2c, flags);
3018 }
3019
3020 static const struct i2c_lock_operations proxy_lock_ops = {
3021         .lock_bus =    proxy_lock_bus,
3022         .trylock_bus = proxy_trylock_bus,
3023         .unlock_bus =  proxy_unlock_bus,
3024 };
3025
3026 static bool
3027 intel_sdvo_init_ddc_proxy(struct intel_sdvo *sdvo,
3028                           struct drm_i915_private *dev_priv)
3029 {
3030         struct pci_dev *pdev = dev_priv->drm.pdev;
3031
3032         sdvo->ddc.owner = THIS_MODULE;
3033         sdvo->ddc.class = I2C_CLASS_DDC;
3034         snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy");
3035         sdvo->ddc.dev.parent = &pdev->dev;
3036         sdvo->ddc.algo_data = sdvo;
3037         sdvo->ddc.algo = &intel_sdvo_ddc_proxy;
3038         sdvo->ddc.lock_ops = &proxy_lock_ops;
3039
3040         return i2c_add_adapter(&sdvo->ddc) == 0;
3041 }
3042
3043 static void assert_sdvo_port_valid(const struct drm_i915_private *dev_priv,
3044                                    enum port port)
3045 {
3046         if (HAS_PCH_SPLIT(dev_priv))
3047                 WARN_ON(port != PORT_B);
3048         else
3049                 WARN_ON(port != PORT_B && port != PORT_C);
3050 }
3051
3052 bool intel_sdvo_init(struct drm_i915_private *dev_priv,
3053                      i915_reg_t sdvo_reg, enum port port)
3054 {
3055         struct intel_encoder *intel_encoder;
3056         struct intel_sdvo *intel_sdvo;
3057         int i;
3058
3059         assert_sdvo_port_valid(dev_priv, port);
3060
3061         intel_sdvo = kzalloc(sizeof(*intel_sdvo), GFP_KERNEL);
3062         if (!intel_sdvo)
3063                 return false;
3064
3065         intel_sdvo->sdvo_reg = sdvo_reg;
3066         intel_sdvo->port = port;
3067         intel_sdvo->slave_addr =
3068                 intel_sdvo_get_slave_addr(dev_priv, intel_sdvo) >> 1;
3069         intel_sdvo_select_i2c_bus(dev_priv, intel_sdvo);
3070         if (!intel_sdvo_init_ddc_proxy(intel_sdvo, dev_priv))
3071                 goto err_i2c_bus;
3072
3073         /* encoder type will be decided later */
3074         intel_encoder = &intel_sdvo->base;
3075         intel_encoder->type = INTEL_OUTPUT_SDVO;
3076         intel_encoder->power_domain = POWER_DOMAIN_PORT_OTHER;
3077         intel_encoder->port = port;
3078         drm_encoder_init(&dev_priv->drm, &intel_encoder->base,
3079                          &intel_sdvo_enc_funcs, 0,
3080                          "SDVO %c", port_name(port));
3081
3082         /* Read the regs to test if we can talk to the device */
3083         for (i = 0; i < 0x40; i++) {
3084                 u8 byte;
3085
3086                 if (!intel_sdvo_read_byte(intel_sdvo, i, &byte)) {
3087                         DRM_DEBUG_KMS("No SDVO device found on %s\n",
3088                                       SDVO_NAME(intel_sdvo));
3089                         goto err;
3090                 }
3091         }
3092
3093         intel_encoder->compute_config = intel_sdvo_compute_config;
3094         if (HAS_PCH_SPLIT(dev_priv)) {
3095                 intel_encoder->disable = pch_disable_sdvo;
3096                 intel_encoder->post_disable = pch_post_disable_sdvo;
3097         } else {
3098                 intel_encoder->disable = intel_disable_sdvo;
3099         }
3100         intel_encoder->pre_enable = intel_sdvo_pre_enable;
3101         intel_encoder->enable = intel_enable_sdvo;
3102         intel_encoder->get_hw_state = intel_sdvo_get_hw_state;
3103         intel_encoder->get_config = intel_sdvo_get_config;
3104
3105         /* In default case sdvo lvds is false */
3106         if (!intel_sdvo_get_capabilities(intel_sdvo, &intel_sdvo->caps))
3107                 goto err;
3108
3109         if (intel_sdvo_output_setup(intel_sdvo,
3110                                     intel_sdvo->caps.output_flags) != true) {
3111                 DRM_DEBUG_KMS("SDVO output failed to setup on %s\n",
3112                               SDVO_NAME(intel_sdvo));
3113                 /* Output_setup can leave behind connectors! */
3114                 goto err_output;
3115         }
3116
3117         /*
3118          * Only enable the hotplug irq if we need it, to work around noisy
3119          * hotplug lines.
3120          */
3121         if (intel_sdvo->hotplug_active) {
3122                 if (intel_sdvo->port == PORT_B)
3123                         intel_encoder->hpd_pin = HPD_SDVO_B;
3124                 else
3125                         intel_encoder->hpd_pin = HPD_SDVO_C;
3126         }
3127
3128         /*
3129          * Cloning SDVO with anything is often impossible, since the SDVO
3130          * encoder can request a special input timing mode. And even if that's
3131          * not the case we have evidence that cloning a plain unscaled mode with
3132          * VGA doesn't really work. Furthermore the cloning flags are way too
3133          * simplistic anyway to express such constraints, so just give up on
3134          * cloning for SDVO encoders.
3135          */
3136         intel_sdvo->base.cloneable = 0;
3137
3138         intel_sdvo_select_ddc_bus(dev_priv, intel_sdvo);
3139
3140         /* Set the input timing to the screen. Assume always input 0. */
3141         if (!intel_sdvo_set_target_input(intel_sdvo))
3142                 goto err_output;
3143
3144         if (!intel_sdvo_get_input_pixel_clock_range(intel_sdvo,
3145                                                     &intel_sdvo->pixel_clock_min,
3146                                                     &intel_sdvo->pixel_clock_max))
3147                 goto err_output;
3148
3149         DRM_DEBUG_KMS("%s device VID/DID: %02X:%02X.%02X, "
3150                         "clock range %dMHz - %dMHz, "
3151                         "input 1: %c, input 2: %c, "
3152                         "output 1: %c, output 2: %c\n",
3153                         SDVO_NAME(intel_sdvo),
3154                         intel_sdvo->caps.vendor_id, intel_sdvo->caps.device_id,
3155                         intel_sdvo->caps.device_rev_id,
3156                         intel_sdvo->pixel_clock_min / 1000,
3157                         intel_sdvo->pixel_clock_max / 1000,
3158                         (intel_sdvo->caps.sdvo_inputs_mask & 0x1) ? 'Y' : 'N',
3159                         (intel_sdvo->caps.sdvo_inputs_mask & 0x2) ? 'Y' : 'N',
3160                         /* check currently supported outputs */
3161                         intel_sdvo->caps.output_flags &
3162                         (SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_RGB0) ? 'Y' : 'N',
3163                         intel_sdvo->caps.output_flags &
3164                         (SDVO_OUTPUT_TMDS1 | SDVO_OUTPUT_RGB1) ? 'Y' : 'N');
3165         return true;
3166
3167 err_output:
3168         intel_sdvo_output_cleanup(intel_sdvo);
3169
3170 err:
3171         drm_encoder_cleanup(&intel_encoder->base);
3172         i2c_del_adapter(&intel_sdvo->ddc);
3173 err_i2c_bus:
3174         intel_sdvo_unselect_i2c_bus(intel_sdvo);
3175         kfree(intel_sdvo);
3176
3177         return false;
3178 }