ASoC: Intel: Skylake: Fix potential NULL pointer dereference
authorPankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Tue, 7 Nov 2017 10:46:18 +0000 (16:16 +0530)
committerMark Brown <broonie@kernel.org>
Wed, 8 Nov 2017 18:56:13 +0000 (18:56 +0000)
Pointer 'mconfig' returned from call to skl_tplg_fe_get_cpr_module() can
be NULL. So check for the valid pointer before dereferencing.

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl-pcm.c

index 2b1e513b1680e4c73130710c318e8fe50855c59c..a3cb204e9640fa36052bb2caf685ac465e051262 100644 (file)
@@ -355,7 +355,8 @@ static void skl_pcm_close(struct snd_pcm_substream *substream,
        }
 
        mconfig = skl_tplg_fe_get_cpr_module(dai, substream->stream);
        }
 
        mconfig = skl_tplg_fe_get_cpr_module(dai, substream->stream);
-       skl_tplg_d0i3_put(skl, mconfig->d0i3_caps);
+       if (mconfig)
+               skl_tplg_d0i3_put(skl, mconfig->d0i3_caps);
 
        kfree(dma_params);
 }
 
        kfree(dma_params);
 }