Merge branch 'mailbox-for-next' of git://git.linaro.org/landing-teams/working/fujitsu...
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 7 Jul 2017 17:24:07 +0000 (10:24 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 7 Jul 2017 17:24:07 +0000 (10:24 -0700)
Pull mailbox updates from Jassi Brar:

 - Minor improvement : avoid requiring unnecessary startup/shutdown
   callback that many drivers seem to not need

 - New controller driver for Qualcomm's APCS IPC

* 'mailbox-for-next' of git://git.linaro.org/landing-teams/working/fujitsu/integration:
  mailbox: Introduce Qualcomm APCS IPC driver
  dt-bindings: mailbox: Introduce Qualcomm APCS global binding
  mailbox: Make startup and shutdown ops optional

Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt [new file with mode: 0644]
drivers/mailbox/Kconfig
drivers/mailbox/Makefile
drivers/mailbox/mailbox.c
drivers/mailbox/qcom-apcs-ipc-mailbox.c [new file with mode: 0644]

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
new file mode 100644 (file)
index 0000000..fb961c3
--- /dev/null
@@ -0,0 +1,46 @@
+Binding for the Qualcomm APCS global block
+==========================================
+
+This binding describes the APCS "global" block found in various Qualcomm
+platforms.
+
+- compatible:
+       Usage: required
+       Value type: <string>
+       Definition: must be one of:
+                   "qcom,msm8916-apcs-kpss-global",
+                   "qcom,msm8996-apcs-hmss-global"
+
+- reg:
+       Usage: required
+       Value type: <prop-encoded-array>
+       Definition: must specify the base address and size of the global block
+
+- #mbox-cells:
+       Usage: required
+       Value type: <u32>
+       Definition: as described in mailbox.txt, must be 1
+
+
+= EXAMPLE
+The following example describes the APCS HMSS found in MSM8996 and part of the
+GLINK RPM referencing the "rpm_hlos" doorbell therein.
+
+       apcs_glb: mailbox@9820000 {
+               compatible = "qcom,msm8996-apcs-hmss-global";
+               reg = <0x9820000 0x1000>;
+
+               #mbox-cells = <1>;
+       };
+
+       rpm-glink {
+               compatible = "qcom,glink-rpm";
+
+               interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
+
+               qcom,rpm-msg-ram = <&rpm_msg_ram>;
+
+               mboxes = <&apcs_glb 0>;
+               mbox-names = "rpm_hlos";
+       };
+
index ee1a3d9147ef064446bf6f63fec31683c859d8f2..c5731e5e3c6c5be67f24e2b0b68be54db14559da 100644 (file)
@@ -124,6 +124,14 @@ config MAILBOX_TEST
          Test client to help with testing new Controller driver
          implementations.
 
+config QCOM_APCS_IPC
+       tristate "Qualcomm APCS IPC driver"
+       depends on ARCH_QCOM || COMPILE_TEST
+       help
+         Say y here to enable support for the APCS IPC mailbox driver,
+         providing an interface for invoking the inter-process communication
+         signals from the application processor to other masters.
+
 config TEGRA_HSP_MBOX
        bool "Tegra HSP (Hardware Synchronization Primitives) Driver"
        depends on ARCH_TEGRA_186_SOC
index e2bcb03cd35b2e87c3d1c510f992a3a1f041334e..d54e41206e175e1f6da697fa8d4415e8fd1cf75d 100644 (file)
@@ -32,4 +32,6 @@ obj-$(CONFIG_BCM_PDC_MBOX)    += bcm-pdc-mailbox.o
 
 obj-$(CONFIG_BCM_FLEXRM_MBOX)  += bcm-flexrm-mailbox.o
 
+obj-$(CONFIG_QCOM_APCS_IPC)    += qcom-apcs-ipc-mailbox.o
+
 obj-$(CONFIG_TEGRA_HSP_MBOX)   += tegra-hsp.o
index 9dfbf7ea10a230579fbe4d102d491b045a8ea5b2..537f4f6d009b2d0dbd1eeac62dd20212eef3fb02 100644 (file)
@@ -355,11 +355,14 @@ struct mbox_chan *mbox_request_channel(struct mbox_client *cl, int index)
 
        spin_unlock_irqrestore(&chan->lock, flags);
 
-       ret = chan->mbox->ops->startup(chan);
-       if (ret) {
-               dev_err(dev, "Unable to startup the chan (%d)\n", ret);
-               mbox_free_channel(chan);
-               chan = ERR_PTR(ret);
+       if (chan->mbox->ops->startup) {
+               ret = chan->mbox->ops->startup(chan);
+
+               if (ret) {
+                       dev_err(dev, "Unable to startup the chan (%d)\n", ret);
+                       mbox_free_channel(chan);
+                       chan = ERR_PTR(ret);
+               }
        }
 
        mutex_unlock(&con_mutex);
@@ -408,7 +411,8 @@ void mbox_free_channel(struct mbox_chan *chan)
        if (!chan || !chan->cl)
                return;
 
-       chan->mbox->ops->shutdown(chan);
+       if (chan->mbox->ops->shutdown)
+               chan->mbox->ops->shutdown(chan);
 
        /* The queued TX requests are simply aborted, no callbacks are made */
        spin_lock_irqsave(&chan->lock, flags);
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
new file mode 100644 (file)
index 0000000..9924c6d
--- /dev/null
@@ -0,0 +1,129 @@
+/*
+ * Copyright (c) 2017, Linaro Ltd
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/io.h>
+#include <linux/slab.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+#include <linux/mailbox_controller.h>
+
+#define QCOM_APCS_IPC_BITS     32
+
+struct qcom_apcs_ipc {
+       struct mbox_controller mbox;
+       struct mbox_chan mbox_chans[QCOM_APCS_IPC_BITS];
+
+       void __iomem *reg;
+       unsigned long offset;
+};
+
+static int qcom_apcs_ipc_send_data(struct mbox_chan *chan, void *data)
+{
+       struct qcom_apcs_ipc *apcs = container_of(chan->mbox,
+                                                 struct qcom_apcs_ipc, mbox);
+       unsigned long idx = (unsigned long)chan->con_priv;
+
+       writel(BIT(idx), apcs->reg);
+
+       return 0;
+}
+
+static const struct mbox_chan_ops qcom_apcs_ipc_ops = {
+       .send_data = qcom_apcs_ipc_send_data,
+};
+
+static int qcom_apcs_ipc_probe(struct platform_device *pdev)
+{
+       struct qcom_apcs_ipc *apcs;
+       struct resource *res;
+       unsigned long offset;
+       void __iomem *base;
+       unsigned long i;
+       int ret;
+
+       apcs = devm_kzalloc(&pdev->dev, sizeof(*apcs), GFP_KERNEL);
+       if (!apcs)
+               return -ENOMEM;
+
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       base = devm_ioremap_resource(&pdev->dev, res);
+       if (IS_ERR(base))
+               return PTR_ERR(base);
+
+       offset = (unsigned long)of_device_get_match_data(&pdev->dev);
+
+       apcs->reg = base + offset;
+
+       /* Initialize channel identifiers */
+       for (i = 0; i < ARRAY_SIZE(apcs->mbox_chans); i++)
+               apcs->mbox_chans[i].con_priv = (void *)i;
+
+       apcs->mbox.dev = &pdev->dev;
+       apcs->mbox.ops = &qcom_apcs_ipc_ops;
+       apcs->mbox.chans = apcs->mbox_chans;
+       apcs->mbox.num_chans = ARRAY_SIZE(apcs->mbox_chans);
+
+       ret = mbox_controller_register(&apcs->mbox);
+       if (ret) {
+               dev_err(&pdev->dev, "failed to register APCS IPC controller\n");
+               return ret;
+       }
+
+       platform_set_drvdata(pdev, apcs);
+
+       return 0;
+}
+
+static int qcom_apcs_ipc_remove(struct platform_device *pdev)
+{
+       struct qcom_apcs_ipc *apcs = platform_get_drvdata(pdev);
+
+       mbox_controller_unregister(&apcs->mbox);
+
+       return 0;
+}
+
+/* .data is the offset of the ipc register within the global block */
+static const struct of_device_id qcom_apcs_ipc_of_match[] = {
+       { .compatible = "qcom,msm8916-apcs-kpss-global", .data = (void *)8 },
+       { .compatible = "qcom,msm8996-apcs-hmss-global", .data = (void *)16 },
+       {}
+};
+MODULE_DEVICE_TABLE(of, qcom_apcs_ipc_of_match);
+
+static struct platform_driver qcom_apcs_ipc_driver = {
+       .probe = qcom_apcs_ipc_probe,
+       .remove = qcom_apcs_ipc_remove,
+       .driver = {
+               .name = "qcom_apcs_ipc",
+               .of_match_table = qcom_apcs_ipc_of_match,
+       },
+};
+
+static int __init qcom_apcs_ipc_init(void)
+{
+       return platform_driver_register(&qcom_apcs_ipc_driver);
+}
+postcore_initcall(qcom_apcs_ipc_init);
+
+static void __exit qcom_apcs_ipc_exit(void)
+{
+       platform_driver_unregister(&qcom_apcs_ipc_driver);
+}
+module_exit(qcom_apcs_ipc_exit);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Qualcomm APCS IPC driver");