spi: pxa2xx: avoid redundant gpio_to_desc(desc_to_gpio()) round-trip
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Thu, 21 Dec 2017 00:37:31 +0000 (01:37 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 21 Dec 2017 12:19:02 +0000 (12:19 +0000)
gpio_free(gpio) simply does gpiod_free(gpio_to_desc(gpio)), so it's
simpler and cleaner to use gpiod_free directly.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx.c

index 4cb515a3104c1759b451c1f2d313953c009fb3ce..c209dc1047b57bd78ca25204a220ce85b8319558 100644 (file)
@@ -1237,7 +1237,7 @@ static int setup_cs(struct spi_device *spi, struct chip_data *chip,
         * different chip_info, release previously requested GPIO
         */
        if (chip->gpiod_cs) {
         * different chip_info, release previously requested GPIO
         */
        if (chip->gpiod_cs) {
-               gpio_free(desc_to_gpio(chip->gpiod_cs));
+               gpiod_free(chip->gpiod_cs);
                chip->gpiod_cs = NULL;
        }
 
                chip->gpiod_cs = NULL;
        }
 
@@ -1417,7 +1417,7 @@ static void cleanup(struct spi_device *spi)
 
        if (drv_data->ssp_type != CE4100_SSP && !drv_data->cs_gpiods &&
            chip->gpiod_cs)
 
        if (drv_data->ssp_type != CE4100_SSP && !drv_data->cs_gpiods &&
            chip->gpiod_cs)
-               gpio_free(desc_to_gpio(chip->gpiod_cs));
+               gpiod_free(chip->gpiod_cs);
 
        kfree(chip);
 }
 
        kfree(chip);
 }