eCryptfs: constify attribute_group structures.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Fri, 30 Jun 2017 09:33:23 +0000 (15:03 +0530)
committerTyler Hicks <tyhicks@canonical.com>
Wed, 8 Nov 2017 17:38:14 +0000 (17:38 +0000)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
   6122     636      24    6782    1a7e fs/ecryptfs/main.o

File size After adding 'const':
   text    data     bss     dec     hex filename
   6186     604      24    6814    1a9e fs/ecryptfs/main.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
fs/ecryptfs/main.c

index 1a419c3b8d4f65a0686399b67a4259a4f5ee3bcf..d0b438eff82d4924ca50585e7516e7fda5a54634 100644 (file)
@@ -781,7 +781,7 @@ static struct attribute *attributes[] = {
        NULL,
 };
 
        NULL,
 };
 
-static struct attribute_group attr_group = {
+static const struct attribute_group attr_group = {
        .attrs = attributes,
 };
 
        .attrs = attributes,
 };