Input: raspberrypi-ts - fix link error
authorAnders Roxell <>
Mon, 14 Jan 2019 18:30:04 +0000 (10:30 -0800)
committerDmitry Torokhov <>
Mon, 14 Jan 2019 18:34:07 +0000 (10:34 -0800)
Fix link error when TOUCHSCREEN_RASPBERRYPI_FW is enabled as a module and
the dependent module is built-in.  The 'depends on RASPBERRYPI_FIRMWARE' by
itself prevents the touchscreen driver from being built-in when the
firmware is configured as a module.  However, the '|| COMPILE_TEST' still
allows it unless we explicitly prevent that configuration with

ld: drivers/input/touchscreen/raspberrypi-ts.o: in function `rpi_ts_probe':
raspberrypi-ts.c:(.text+0x3a8): undefined reference to `rpi_firmware_get'
ld: raspberrypi-ts.c:(.text+0x3a8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `rpi_firmware_get'
ld: raspberrypi-ts.c:(.text+0x4c8): undefined reference to `rpi_firmware_property'
ld: raspberrypi-ts.c:(.text+0x4c8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `rpi_firmware_property'

Rework so that TOUCHSCREEN_RASPBERRYPI_FW depends on

Fixes: 0b9f28fed3f7 ("Input: add official Raspberry Pi's touchscreen driver")
Suggested-by: Arnd Bergmann <>
Signed-off-by: Anders Roxell <>
Signed-off-by: Dmitry Torokhov <>

index a391eacf8cf68b1bd18372515e48b0fbdd109025..d171e39485d1249484589b3ef48fabf205cf1196 100644 (file)
@@ -685,7 +685,7 @@ config TOUCHSCREEN_EDT_FT5X06
        tristate "Raspberry Pi's firmware base touch screen support"
          Say Y here if you have the official Raspberry Pi 7 inch screen on
          your system.