fs: dcache: Use true and false for boolean values
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 2 Aug 2018 00:39:05 +0000 (19:39 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 5 Aug 2018 19:52:44 +0000 (15:52 -0400)
Return statements in functions returning bool should use true or false
instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/dcache.c

index 0e8e5de3c48a56e24a70b0185932644ba92b93b0..6fd5c1aa4620e5305008b893377fb06efe8d7eae 100644 (file)
@@ -732,16 +732,16 @@ static inline bool fast_dput(struct dentry *dentry)
                if (dentry->d_lockref.count > 1) {
                        dentry->d_lockref.count--;
                        spin_unlock(&dentry->d_lock);
                if (dentry->d_lockref.count > 1) {
                        dentry->d_lockref.count--;
                        spin_unlock(&dentry->d_lock);
-                       return 1;
+                       return true;
                }
                }
-               return 0;
+               return false;
        }
 
        /*
         * If we weren't the last ref, we're done.
         */
        if (ret)
        }
 
        /*
         * If we weren't the last ref, we're done.
         */
        if (ret)
-               return 1;
+               return true;
 
        /*
         * Careful, careful. The reference count went down
 
        /*
         * Careful, careful. The reference count went down
@@ -770,7 +770,7 @@ static inline bool fast_dput(struct dentry *dentry)
 
        /* Nothing to do? Dropping the reference was all we needed? */
        if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry))
 
        /* Nothing to do? Dropping the reference was all we needed? */
        if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry))
-               return 1;
+               return true;
 
        /*
         * Not the fast normal case? Get the lock. We've already decremented
 
        /*
         * Not the fast normal case? Get the lock. We've already decremented
@@ -787,7 +787,7 @@ static inline bool fast_dput(struct dentry *dentry)
         */
        if (dentry->d_lockref.count) {
                spin_unlock(&dentry->d_lock);
         */
        if (dentry->d_lockref.count) {
                spin_unlock(&dentry->d_lock);
-               return 1;
+               return true;
        }
 
        /*
        }
 
        /*
@@ -796,7 +796,7 @@ static inline bool fast_dput(struct dentry *dentry)
         * set it to 1.
         */
        dentry->d_lockref.count = 1;
         * set it to 1.
         */
        dentry->d_lockref.count = 1;
-       return 0;
+       return false;
 }
 
 
 }