fs/proc/vmcore.c: hide vmcoredd_mmap_dumps() for nommu builds
authorArnd Bergmann <arnd@arndb.de>
Fri, 24 Aug 2018 00:00:55 +0000 (17:00 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 24 Aug 2018 01:48:43 +0000 (18:48 -0700)
Without CONFIG_MMU, we get a build warning:

  fs/proc/vmcore.c:228:12: error: 'vmcoredd_mmap_dumps' defined but not used [-Werror=unused-function]
   static int vmcoredd_mmap_dumps(struct vm_area_struct *vma, unsigned long dst,

The function is only referenced from an #ifdef'ed caller, so
this uses the same #ifdef around it.

Link: http://lkml.kernel.org/r/20180525213526.2117790-1-arnd@arndb.de
Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Ganesh Goudar <ganeshgr@chelsio.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

index 6c1c2607e9e4cf392e5faf05182a572f1c4bb175..cbde728f8ac60958a8662367c47ee2afe02af25d 100644 (file)
@@ -225,6 +225,7 @@ out_unlock:
        return ret;
+#ifdef CONFIG_MMU
 static int vmcoredd_mmap_dumps(struct vm_area_struct *vma, unsigned long dst,
                               u64 start, size_t size)
@@ -259,6 +260,7 @@ out_unlock:
        return ret;
+#endif /* CONFIG_MMU */
 /* Read from the ELF header and then the crash dump. On error, negative value is