ALSA: aoa: Constify snd_kcontrol_new items
authorTakashi Iwai <tiwai@suse.de>
Fri, 3 Jan 2020 08:16:48 +0000 (09:16 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 3 Jan 2020 08:24:22 +0000 (09:24 +0100)
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.

There should be no functional changes by this patch.

Link: https://lore.kernel.org/r/20200103081714.9560-33-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/aoa/codecs/onyx.c
sound/aoa/codecs/tas.c
sound/aoa/fabrics/layout.c

index 83ab3e5..f85bc8a 100644 (file)
@@ -413,7 +413,7 @@ static int onyx_snd_single_bit_put(struct snd_kcontrol *kcontrol,
 }
 
 #define SINGLE_BIT(n, type, description, address, mask, flags)         \
-static struct snd_kcontrol_new n##_control = {                         \
+static const struct snd_kcontrol_new n##_control = {                   \
        .iface = SNDRV_CTL_ELEM_IFACE_##type,                           \
        .name = description,                                            \
        .access = SNDRV_CTL_ELEM_ACCESS_READWRITE,                      \
index c60b783..d3e3757 100644 (file)
@@ -369,7 +369,7 @@ static int tas_snd_mixer_put(struct snd_kcontrol *kcontrol,
 }
 
 #define MIXER_CONTROL(n,descr,idx)                     \
-static struct snd_kcontrol_new n##_control = {         \
+static const struct snd_kcontrol_new n##_control = {   \
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,            \
        .name = descr " Playback Volume",               \
        .access = SNDRV_CTL_ELEM_ACCESS_READWRITE,      \
index 801b2f7..d2e85b8 100644 (file)
@@ -655,7 +655,7 @@ static int n##_control_put(struct snd_kcontrol *kcontrol,           \
                        !!ucontrol->value.integer.value[0]);            \
        return 1;                                                       \
 }                                                                      \
-static struct snd_kcontrol_new n##_ctl = {                             \
+static const struct snd_kcontrol_new n##_ctl = {                       \
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,                            \
        .name = description,                                            \
        .access = SNDRV_CTL_ELEM_ACCESS_READWRITE,                      \