cma: fix calculation of aligned offset
authorDoug Berger <>
Mon, 10 Jul 2017 22:49:44 +0000 (15:49 -0700)
committerLinus Torvalds <>
Mon, 10 Jul 2017 23:32:32 +0000 (16:32 -0700)
The align_offset parameter is used by bitmap_find_next_zero_area_off()
to represent the offset of map's base from the previous alignment
boundary; the function ensures that the returned index, plus the
align_offset, honors the specified align_mask.

The logic introduced by commit b5be83e308f7 ("mm: cma: align to physical
address, not CMA region position") has the cma driver calculate the
offset to the *next* alignment boundary.  In most cases, the base
alignment is greater than that specified when making allocations,
resulting in a zero offset whether we align up or down.  In the example
given with the commit, the base alignment (8MB) was half the requested
alignment (16MB) so the math also happened to work since the offset is
8MB in both directions.  However, when requesting allocations with an
alignment greater than twice that of the base, the returned index would
not be correctly aligned.

Also, the align_order arguments of cma_bitmap_aligned_mask() and
cma_bitmap_aligned_offset() should not be negative so the argument type
was made unsigned.

Fixes: b5be83e308f7 ("mm: cma: align to physical address, not CMA region position")
Signed-off-by: Angus Clark <>
Signed-off-by: Doug Berger <>
Acked-by: Gregory Fong <>
Cc: Doug Berger <>
Cc: Angus Clark <>
Cc: Laura Abbott <>
Cc: Vlastimil Babka <>
Cc: Greg Kroah-Hartman <>
Cc: Lucas Stach <>
Cc: Catalin Marinas <>
Cc: Shiraz Hashim <>
Cc: Jaewon Kim <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>

index 9e45491917895a23f5bcf49ef5d16596cbf93aeb..c0da318c020e6c6d666ac8cf7cb92b2d4a47ceae 100644 (file)
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -59,7 +59,7 @@ const char *cma_get_name(const struct cma *cma)
 static unsigned long cma_bitmap_aligned_mask(const struct cma *cma,
-                                            int align_order)
+                                            unsigned int align_order)
        if (align_order <= cma->order_per_bit)
                return 0;
@@ -67,17 +67,14 @@ static unsigned long cma_bitmap_aligned_mask(const struct cma *cma,
- * Find a PFN aligned to the specified order and return an offset represented in
- * order_per_bits.
+ * Find the offset of the base PFN from the specified align_order.
+ * The value returned is represented in order_per_bits.
 static unsigned long cma_bitmap_aligned_offset(const struct cma *cma,
-                                              int align_order)
+                                              unsigned int align_order)
-       if (align_order <= cma->order_per_bit)
-               return 0;
-       return (ALIGN(cma->base_pfn, (1UL << align_order))
-               - cma->base_pfn) >> cma->order_per_bit;
+       return (cma->base_pfn & ((1UL << align_order) - 1))
+               >> cma->order_per_bit;
 static unsigned long cma_bitmap_pages_to_bits(const struct cma *cma,