security_file_open(): lose cred argument
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 10 Jul 2018 17:25:29 +0000 (13:25 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 12 Jul 2018 14:04:15 +0000 (10:04 -0400)
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/open.c
include/linux/security.h
security/security.c

index 0a9f00b..4c65ede 100644 (file)
--- a/fs/open.c
+++ b/fs/open.c
@@ -776,7 +776,7 @@ static int do_dentry_open(struct file *f,
                goto cleanup_all;
        }
 
-       error = security_file_open(f, f->f_cred);
+       error = security_file_open(f);
        if (error)
                goto cleanup_all;
 
index 63030c8..88d30fc 100644 (file)
@@ -309,7 +309,7 @@ void security_file_set_fowner(struct file *file);
 int security_file_send_sigiotask(struct task_struct *tsk,
                                 struct fown_struct *fown, int sig);
 int security_file_receive(struct file *file);
-int security_file_open(struct file *file, const struct cred *cred);
+int security_file_open(struct file *file);
 int security_task_alloc(struct task_struct *task, unsigned long clone_flags);
 void security_task_free(struct task_struct *task);
 int security_cred_alloc_blank(struct cred *cred, gfp_t gfp);
@@ -858,8 +858,7 @@ static inline int security_file_receive(struct file *file)
        return 0;
 }
 
-static inline int security_file_open(struct file *file,
-                                    const struct cred *cred)
+static inline int security_file_open(struct file *file)
 {
        return 0;
 }
index 68f46d8..235b35f 100644 (file)
@@ -970,11 +970,11 @@ int security_file_receive(struct file *file)
        return call_int_hook(file_receive, 0, file);
 }
 
-int security_file_open(struct file *file, const struct cred *cred)
+int security_file_open(struct file *file)
 {
        int ret;
 
-       ret = call_int_hook(file_open, 0, file, cred);
+       ret = call_int_hook(file_open, 0, file, file->f_cred);
        if (ret)
                return ret;