PM / OPP: Update performance state when freq == old_freq
authorViresh Kumar <>
Tue, 12 Mar 2019 04:57:18 +0000 (10:27 +0530)
committerRafael J. Wysocki <>
Tue, 12 Mar 2019 08:45:56 +0000 (09:45 +0100)
At boot up, CPUFreq core performs a sanity check to see if the system is
running at a frequency defined in the frequency table of the CPU. If so,
we try to find a valid frequency (lowest frequency greater than the
currently programmed frequency) from the table and set it. When the call
reaches dev_pm_opp_set_rate(), it calls _find_freq_ceil(opp_table,
&old_freq) to find the previously configured OPP and this call also
updates the old_freq. This eventually sets the old_freq == freq (new
target requested by cpufreq core) and we skip updating the performance
state in this case.

Fix this by also updating the performance state when the old_freq ==

Fixes: ca1b5d77b1c6 ("OPP: Configure all required OPPs")
Cc: v5.0 <> # v5.0
Reported-by: Niklas Cassel <>
Tested-by: Jorge Ramirez-Ortiz <>
Signed-off-by: Viresh Kumar <>
Signed-off-by: Rafael J. Wysocki <>

index d7f9716..0420f7e 100644 (file)
@@ -760,7 +760,7 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
                old_freq, freq);
        /* Scaling up? Configure required OPPs before frequency */
-       if (freq > old_freq) {
+       if (freq >= old_freq) {
                ret = _set_required_opps(dev, opp_table, opp);
                if (ret)
                        goto put_opp;